Skip to content

24xx clock fixes: DSP, 54MHz APLL

Paul Walmsley linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32430 clock: remove redundant iva2_1_fckarch/arm/mach-omap2/clock24xx.h+33 -700 replies
2/324xx clock: clarify clock structure; correct parent clockarch/arm/mach-omap2/clock24xx.h drivers/dsp/dspgateway/dsp_common.c+38 -470 replies
3/324xx clock: Fix 54MHz APLL readiness testarch/arm/mach-omap2/clock24xx.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] 24xx clock fixes: DSP, 54MHz APLL

Hello,

these patches clean up the structure of the DSP clocks on the OMAP24xx platforms. They remove redundant clocks and rate structures, and fix the DSP driver code to use the correct clock name on 2430. DSP i-clock source selection is moved into a separate clock, dsp_irate_ick, to facilitate some of this consolidation.

Also, in omap2_clk_fixed_enable(), it turns out that we were looking for the wrong IDLEST bit to test if the 54MHz APLL was locked - fix this.

This series resolves the boot-time clock warnings that appear on 2430SDP:

clock: Could not find parent clock iva2_1_fck in clksel array of clock iva2_1_ick

omapdsp: could not acquire dsp_ick handle

Clock apll54_ck didn't enable in 100000 tries

Boot-tested on N800 and 2430SDP. Comments welcome.

- Paul

diffstat:

 arch/arm/mach-omap2/clock24xx.c     |    2
 arch/arm/mach-omap2/clock24xx.h     |  180 ++++++++++++------------------------
 drivers/dsp/dspgateway/dsp_common.c |    8 +
 3 files changed, 72 insertions(+), 118 deletions(-)

size:

text data bss dec hex filename

2741640  141712   84116 2967468  2d47ac vmlinux.n800.orig
2741244  141712   84116 2967072  2d4620 vmlinux.n800.patched