ide-cd: redux
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 63 patches 10 repliesIn review
Changes from the cover letter
* unify _four_ slightly different IRQ handlers into one
* re-organize handling of quirky-devices (group quirks scattered all over the driver in the table and handle them using flags)
* move code for verbose error logging to ide-cd_verbose.c (this code doesn't have any IDE subsystem dependencies so if desired it can be easily converted into generic IDE/libata library)
* move code handling cdrom.c IOCTLs to ide-cd_ioctl.c
* remove duplicated/dead code (> 700 LOC gone)
* move historical changelog to Documentation/ide/
* fix few bugs discovered during rewrite
2 of 63 patches are in this archive. The cover letter announces 63.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 6/63 | ide-cd: fix error messages in cdrom_write_intr()drivers/ | +8 | 1 reply | |
| 7/63 | ide-cd: add error message for DMA error to cdrom_read_intr()drivers/ | +4 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Sergei Shtylyov |
|---|---|
| 6/63 | A-b |
| 7/63 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/63] ide-cd: redux
Hi,
This patch series is a major rework of the ide-cd driver.
The motivations behind it are twofold:
* ide-cd is still in use but because it has been out of luck for maintainers lately the code become quite hard to debug and maintain - this puts it back into the shape
* aid efforts of developers (Tejun and Alan) who are working on libata ATAPI support - it should be now a lot easier to spot the various quirks for weird/buggy devices, differences between sr/ide-cd etc.
This patch series contains only safe/straightforward changes (some "risky" ones are scheduled for later time) and should be fully bisectable.
Changes:
* unify _four_ slightly different IRQ handlers into one
* re-organize handling of quirky-devices (group quirks scattered all over the driver in the table and handle them using flags)
* move code for verbose error logging to ide-cd_verbose.c (this code doesn't have any IDE subsystem dependencies so if desired it can be easily converted into generic IDE/libata library)
* move code handling cdrom.c IOCTLs to ide-cd_ioctl.c
* remove duplicated/dead code (> 700 LOC gone)
* move historical changelog to Documentation/ide/
* fix few bugs discovered during rewrite
diffstat:
Documentation/ide/ChangeLog.ide-cd.1994-2004 | 268 ++ drivers/cdrom/cdrom.c | 6 drivers/ide/Kconfig | 9 drivers/ide/Makefile | 6 drivers/ide/ide-cd.c | 3236 +++++++++------------------ drivers/ide/ide-cd.h | 737 ------ drivers/ide/ide-cd_ioctl.c | 265 ++ drivers/ide/ide-cd_verbose.c | 359 ++ include/linux/cdrom.h | 14 9 files changed, 2095 insertions(+), 2805 deletions(-)
PS ide-cd Maintainer position is still open...
Thanks,
Bart