Skip to content

PM: Do not destroy/create devices while suspended

Rafael J. Wysocki linux-acpi linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PM: Do not destroy/create devices while suspended in msr.carch/x86/kernel/msr.c+0 -32 replies
1/3PM: Do not destroy/create devices while suspended in msr.carch/x86/kernel/msr.c+0 -30 replies
2/3PM: Do not destroy/create devices while suspended in mce_64.carch/x86/kernel/cpu/mcheck/mce_64.c+0 -22 replies
2/3PM: Do not destroy/create devices while suspended in mce_64.carch/x86/kernel/cpu/mcheck/mce_64.c+0 -20 replies
3/3PM: Do not destroy/create devices while suspended in cpuid.carch/x86/kernel/cpuid.c+0 -32 replies
3/3PM: Do not destroy/create devices while suspended in cpuid.carch/x86/kernel/cpuid.c+0 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] PM: Do not destroy/create devices while suspended

Hi,

Some device drivers register CPU hotplug notifiers and use them to destroy device objects when removing the corresponding CPUs and to create these objects when adding the CPUs back.

Unfortunately, this is not the right thing to do during suspend/hibernation, since in that cases the CPU hotplug notifiers are called after suspending devices and before resuming them, so the operations in question are carried out on the objects representing suspended devices which shouldn't be unregistered behing the PM core's back. Although right now it usually doesn't lead to any practical complications, it will predictably deadlock if gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch is applied.

The solution is to prevent drivers from removing/adding devices from within CPU hotplug notifiers during suspend/hibernation using the FROZEN bit in the notifier's action argument. The following three patches modify the MSR, x86-64 MCE and cpuid drivers along these lines.

Thanks,
Rafael