Skip to content

: Make use of new netlink API features

Patrick McHardy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15: sch_atm: fix format string warningnet/sched/sch_atm.c+1 -10 replies
2/15: sch_netem: use nla_parse_nested_compatnet/sched/sch_netem.c+26 -320 replies
3/15: act_api: fix netlink API conversion bugnet/sched/act_api.c+4 -40 replies
4/15: act_api: use nlmsg_parsenet/sched/act_api.c+1 -40 replies
5/15: act_api: use PTR_ERR in tcf_action_init/tcf_action_getinclude/net/act_api.h net/sched/act_api.c net/sched/cls_api.c+48 -410 replies
6/15: Propagate nla_parse return valuenet/sched/act_api.c net/sched/act_gact.c net/sched/act_ipt.c +22 more+171 -600 replies
7/15: Use nla_nest_start/nla_nest_endnet/sched/act_api.c net/sched/act_police.c net/sched/cls_api.c +13 more+166 -1330 replies
8/15: Use NLA_PUT_STRING for string dumpingnet/sched/act_api.c net/sched/act_ipt.c net/sched/cls_api.c +3 more+8 -80 replies
9/15: Use typeful attribute construction helpersnet/sched/act_api.c net/sched/act_ipt.c net/sched/act_police.c +8 more+26 -310 replies
10/15: Use typeful attribute parsing helpersnet/sched/act_api.c net/sched/act_ipt.c net/sched/act_police.c +8 more+27 -290 replies
11/15: sch_api: introduce constant for rate table sizeinclude/linux/pkt_sched.h net/sched/sch_api.c+4 -10 replies
12/15: Use nla_policy for attribute validation in packet schedulersnet/sched/sch_atm.c net/sched/sch_cbq.c net/sched/sch_dsmark.c +6 more+87 -930 replies
13/15: Use nla_policy for attribute validation in classifiersnet/sched/cls_basic.c net/sched/cls_fw.c net/sched/cls_route.c +3 more+59 -680 replies
14/15: Use nla_policy for attribute validation in actionsnet/sched/act_gact.c net/sched/act_ipt.c net/sched/act_mirred.c +4 more+51 -330 replies
15/15: Use nla_policy for attribute validation in ematchesnet/sched/em_meta.c net/sched/ematch.c+12 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NET_SCHED 00/15]: Make use of new netlink API features

Hi Dave,

these patches change the packet schedulers/classifers/actions to make use of the features of the new netlink API, like typeful attribute dumping and parsing, automatic basic attribute validation etc. The also fix a bug and a warning introduced by my last set of patches.

Please apply, thanks.

 include/linux/pkt_sched.h |    2 +
 include/net/act_api.h     |    4 +-
 net/sched/act_api.c       |  197 +++++++++++++++++++++++++--------------------
 net/sched/act_gact.c      |   20 +++--
 net/sched/act_ipt.c       |   33 +++++---
 net/sched/act_mirred.c    |   15 +++-
 net/sched/act_nat.c       |   15 +++-
 net/sched/act_pedit.c     |   15 +++-
 net/sched/act_police.c    |   43 +++++-----
 net/sched/act_simple.c    |   15 +++-
 net/sched/cls_api.c       |   30 ++++---
 net/sched/cls_basic.c     |   33 ++++----
 net/sched/cls_fw.c        |   41 +++++-----
 net/sched/cls_route.c     |   47 +++++------
 net/sched/cls_rsvp.h      |   45 +++++------
 net/sched/cls_tcindex.c   |   70 ++++++++--------
 net/sched/cls_u32.c       |   56 +++++++------
 net/sched/em_meta.c       |   18 +++--
 net/sched/ematch.c        |   31 +++++---
 net/sched/sch_api.c       |    7 +-
 net/sched/sch_atm.c       |   45 ++++++----
 net/sched/sch_cbq.c       |   75 +++++++----------
 net/sched/sch_dsmark.c    |   37 +++++----
 net/sched/sch_gred.c      |   28 +++++--
 net/sched/sch_hfsc.c      |   30 ++++---
 net/sched/sch_htb.c       |   64 ++++++++++-----
 net/sched/sch_ingress.c   |   12 ++--
 net/sched/sch_netem.c     |   73 +++++++---------
 net/sched/sch_prio.c      |    9 ++-
 net/sched/sch_red.c       |   16 +++-
 net/sched/sch_tbf.c       |   29 +++++---
 31 files changed, 650 insertions(+), 505 deletions(-)

Patrick McHardy (15):
[NET_SCHED]: sch_atm: fix format string warning
[NET_SCHED]: sch_netem: use nla_parse_nested_compat [NET_SCHED]: act_api: fix netlink API conversion bug [NET_SCHED]: act_api: use nlmsg_parse
[NET_SCHED]: act_api: use PTR_ERR in tcf_action_init/tcf_action_get [NET_SCHED]: Propagate nla_parse return value
[NET_SCHED]: Use nla_nest_start/nla_nest_end
[NET_SCHED]: Use NLA_PUT_STRING for string dumping [NET_SCHED]: Use typeful attribute construction helpers [NET_SCHED]: Use typeful attribute parsing helpers [NET_SCHED]: sch_api: introduce constant for rate table size [NET_SCHED]: Use nla_policy for attribute validation in packet schedulers [NET_SCHED]: Use nla_policy for attribute validation in classifiers [NET_SCHED]: Use nla_policy for attribute validation in actions [NET_SCHED]: Use nla_policy for attribute validation in ematches