Skip to content

Was: 2.6.24-rc8 hangs at mfgpt-timer

Willy Tarreau lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86: GEODE fix MFGPT input clock valuearch/x86/kernel/mfgpt_32.c+12 -126 replies
2/2x86: GEODE add the "mfgptfix" boot time option to fix MFGPT timersDocumentation/kernel-parameters.txt arch/x86/kernel/mfgpt_32.c+20 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Was: 2.6.24-rc8 hangs at mfgpt-timer
Quoted 9 lines · Ingo Molnar
Quoted 6 lines · Arnd Hannemann
Quoted 5 lines

The attached patch rearranges the code so that the handler is installed before we setup the interrupt (so we have somebody to listen to the immediate interrupt), and it makes sure that we clear the event in the IRQ handler regardless of the state of the timer tick.

Quoted 5 lines
Quoted 2 lines

This patch indeed solves the problem. The board boots fine. Great work!

since this driver is new in 2.6.24, perhaps we should apply this fix to v2.6.24?

Ingo, Jordan,

I have written the two minor patches we were talking about in previous mail. The first one fixes the input clock from 32000 to 32768 Hz, and the second one adds an "mfgptfix" boot parameter to enable the workaround in order to fix a regression on motherboards with a broken BIOS on which 2.6.24-rc8 does not boot anymore whether mfgpt timers are enabled or not.

Jordan, if you think you'll push your changes for 2.6.24, feel free to merge this patch with your work.

Both patches will be sent as a reply to this mail.

Regards,
Willy