Skip to content

Implement some low hanging BKL removal fruit in fs/*

Andi Kleen linux-ext4 linux-fsdevel lkml ocfs2-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18BKL-removal: Convert ext2 over to use unlocked_ioctlfs/ext2/dir.c fs/ext2/ext2.h fs/ext2/file.c +1 more+7 -140 replies
2/18BKL-removal: Remove incorrect BKL comment in ext2fs/ext2/inode.c+0 -10 replies
3/18BKL-removal: Convert ext3 to use unlocked_ioctlfs/ext3/dir.c fs/ext3/file.c fs/ext3/ioctl.c +1 more+14 -142 replies
4/18ext3: Remove incorrect BKL commentfs/ext3/dir.c+1 -10 replies
5/18BKL-removal: Remove incorrect comment refering to lock_kernel() from jbd/jbd2fs/jbd/recovery.c fs/jbd2/recovery.c+2 -20 replies
6/18BKL-removal: Convert ext4 to use unlocked_ioctlfs/ext4/dir.c fs/ext4/file.c fs/ext4/ioctl.c +1 more+14 -130 replies
7/18BKL-removal: Remove incorrect comments refering to BKL from ext4fs/ext4/dir.c fs/ext4/inode.c+1 -20 replies
8/18BKL-removal: Remove BKL from remote_llseekfs/cifs/cifsfs.c fs/gfs2/ops_file.c fs/ncpfs/file.c +4 more+34 -1120 replies
9/18BKL-removal: Use unlocked_ioctl for jfsfs/jfs/file.c fs/jfs/ioctl.c fs/jfs/jfs_inode.h +1 more+13 -71 reply
10/18BKL-removal: Implement a compat_ioctl handler for JFSfs/jfs/file.c fs/jfs/ioctl.c fs/jfs/jfs_dinode.h +2 more+27 -01 reply
11/18BKL-removal: Convert ocfs2 over to unlocked_ioctlfs/ocfs2/file.c fs/ocfs2/ioctl.c fs/ocfs2/ioctl.h+6 -132 replies
12/18BKL-removal: Convert CIFS over to unlocked_ioctlfs/cifs/cifsfs.c fs/cifs/cifsfs.h fs/cifs/ioctl.c+9 -90 replies
13/18BKL-removal: Add compat_ioctl for cifsfs/cifs/cifsfs.c fs/cifs/cifsfs.h fs/cifs/ioctl.c+36 -00 replies
14/18BKL-removal: Add unlocked_fasyncDocumentation/filesystems/vfs.txt fs/fcntl.c fs/ioctl.c +1 more+14 -31 reply
15/18BKL-removal: Convert pipe over to unlocked_fasyncfs/pipe.c+6 -60 replies
16/18BKL-removal: Convert socket fasync to unlocked_fasyncnet/socket.c+1 -10 replies
17/18BKL-removal: Convert fuse to unlocked_fasyncfs/fuse/dev.c+1 -10 replies
18/18BKL-removal: Convert bad_inode to unlocked_fasyncfs/bad_inode.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH] [0/18] Implement some low hanging BKL removal fruit in fs/*

[Andrew: I believe this is -mm material for .25]

- Convert some more file systems (generally those who don't use the BKL for anything except mount) to use unlocked_bkl.
- Implement BKL less fasync (see patch for the rationale) This is currently a separate entry point, but since the number of fasync users in the tree is relatively small I hope the older entry point can be removed then in the not too far future
[help from other people converting more fasync users to unlocked_fasync would be appreciated]
- Implement BKL less remote_llseek
- While I was at it I also added a few missing compat ioctl handlers
- Fix a few comments

This fixes a lot of relatively trivial BKL users in fs/*. The main remaining non legacy offenders are now locks.c, nfs/nfsd and reiserfs. I believe BKL removal for all of those is being worked on by other people. Also a lot of "legacy" file systems still use it, but converting those does not seem to be very pressing.

-Andi

Read the cover letter in its thread