Skip to content

WMI patches for acpi-test

Carlos Corbacho linux-acpi 1 version In review

Get series with b4
b4 am 20080202121718.2286.89857.stgit@pacifica

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ACPI: WMI: Add ACPI-WMI mapping driverMAINTAINERS drivers/acpi/Kconfig drivers/acpi/Makefile +2 more+749 -00 replies
2/5acer-wmi: Add driver for newer Acer laptopsdrivers/misc/Kconfig drivers/misc/Makefile drivers/misc/acer-wmi.c+1126 -00 replies
3/5tc1100-wmi: Add driver for HP Compaq TC1100 Tabletsdrivers/misc/Kconfig drivers/misc/Makefile drivers/misc/tc1100-wmi.c+300 -00 replies
4/5ACPI: WMI: Add sysfs userspace interfacedrivers/acpi/wmi.c include/linux/acpi.h+483 -20 replies
5/5ACPI: WMI: Limit size of device string to 19 charactersdrivers/acpi/wmi.c+1 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchCarlos Corbacho
1/5
2/5
3/5
4/5
5/5NOT-Signed-Off-By

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] WMI patches for acpi-test

Len,

Can you please review, and hopefully apply, at least the first two patches in this series, as I would like to get them into acpi-test (then -mm and eventually 2.6.26-rc1).

It's a little late now to put these into 2.6.25-rc1, and I don't want to miss another merge window - so the sooner these are looked at by you, the sooner I can address any concerns and we can have these ready for the 2.6.26-rc1 window.

-Carlos

===

Patch #1: (WMI - driver and in kernel interface) - Minor clean up

Replace leftover occurences of 'x == NULL' with '!x'

Len: For you to review and to be applied to acpi-test.

====

Patch #2: (acer-wmi) - New DMI entry, mail LED detection fix, mismatch fix

* Don't fail if we can't detect a mail LED on AMW0 systems
* Add an EC quirk for the Acer Aspire 9110
* Fix section mismatch warnings

Len: For you to review and to be applied to acpi-test.

====

Patch #3: (tc1100-wmi) - No Change

RFC only, needs actual testing on the hardware, and probably very broken. Waiting on Matthew Garrett to get some free time to test this.

====

Patch #4: (WMI sysfs interface) - No Change

RFC only (see patch #5 for reason and discussion). Adds interface under /sys/devices/virtual/wmi

Also adds a function to return the (virtual) device associated with a GUID for use by other parts of the kernel that want to set a parent device.

Len: To review (but not to apply yet, unless you want to apply patch #5 as well)

====

Patch #5: (WMI sysfs workaround) - No Change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id length (Kay Sievers is apparently working on this, ref Greg KH[1]).

Len:

Apparently, the necessary fixes _might_ go into 2.6.25 as well, or worst case scenario is 2.6.26[2]. So we can either:

1) Hold off on patch #4 until the necessary fixes go in (this might be 2.6.25 if we're lucky, or we end up putting off WMI sysfs support until 2.6.26)

or

2) Apply patch #4, and #5 on top as a temporary hack, and then revert #5 as soon as the necessary changes go in. (For bisection purposes, #4 and #5 should be merged if we go ahead with this).

I don't know what would be the best solution here.

[1] http://lkml.org/lkml/2007/12/4/30
[2] http://www.nabble.com/Re:-Fix-Firmware-class-name-collision-p14352966.html
---

Carlos Corbacho (5):
[WIP] ACPI: WMI: Limit size of device string to 19 characters [RFC] ACPI: WMI: Add sysfs userspace interface [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
acer-wmi: Add driver for newer Acer laptops
ACPI: WMI: Add ACPI-WMI mapping driver

 MAINTAINERS               |    7 
 drivers/acpi/Kconfig      |   11 
 drivers/acpi/Makefile     |    1 
 drivers/acpi/wmi.c        | 1190 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/Kconfig      |   25 +
 drivers/misc/Makefile     |    2 
 drivers/misc/acer-wmi.c   | 1109 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/tc1100-wmi.c |  290 +++++++++++
 include/linux/acpi.h      |   21 +
 9 files changed, 2656 insertions(+), 0 deletions(-)
 create mode 100644 drivers/acpi/wmi.c
 create mode 100644 drivers/misc/acer-wmi.c
 create mode 100644 drivers/misc/tc1100-wmi.c