Skip to content

ulogd V2 improvements, round 2

[email protected] netfilter-devel 1 version Applied

Status from this message: Applied. Thanks Holger.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 15 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/15Add NACCT output pluginoutput/Makefile.am output/ulogd_output_NACCT.c+210 -11 reply
2/15common.h: addedinclude/ulogd/common.h+50 -01 reply
3/15Replace timer code by working versioninclude/ulogd/ulogd.h src/timer.c+92 -1031 reply
4/15Add IFI listinclude/ulogd/ifi.h src/Makefile.am src/ifi.c +1 more+429 -13 replies
5/15Add signalling subsysteminclude/ulogd/signal.h src/Makefile.am src/select.c +2 more+337 -514 replies
6/15Conffile cleanup, use common pr_debug()src/conffile.c+15 -201 reply
7/15Renice to -1 on startupsrc/ulogd.c+2 -01 reply
8/15Initial round to make plugins reconfigurableinclude/ulogd/ulogd.h src/ulogd.c+87 -00 replies
9/15llist: add llist_for_each_prev_safe()include/ulogd/linuxlist.h+10 -00 replies
10/15Improve select performanceinclude/ulogd/ulogd.h src/select.c src/ulogd.c+92 -791 reply
11/15Add set_sockbuf_len()include/ulogd/common.h src/Makefile.am src/common.c+55 -11 reply
12/15Introduce global state, skip some stacks during reconfigurationinclude/ulogd/ulogd.h src/ulogd.c+92 -210 replies
13/15llist: turn poisoning off by defaultinclude/ulogd/linuxlist.h+2 -00 replies
14/15SQLITE3: port to ulogd 2.00, mostly a rewriteoutput/sqlite3/ulogd_output_SQLITE3.c+683 -2680 replies
15/15NFCT: rework and let it scaleinput/flow/linux_jhash.h input/flow/ulogd_inpflow_NFCT.c+1048 -2770 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ULOGD 00/15] ulogd V2 improvements, round 2

Hi,

this is a follow-up to my previous ulogd V2 improvements patchset send to you as an RFC.

The changes to the previous set of patches are rather small, namely the code of the NFCT plugin contains two small changes after feedback from Pablo Neira.

Because all those changes were strictly chronological, with some of the changes confusingly reverted later, I decided to stuff the NFCT-related changes into one, as well as for the SQLITE3 related ones. Therefore the number of patches reduces from 30 to 15.

After the feedback I've got I'll suggest to apply all the patches without the last NFCT one. It is applied just as an RFC.

My intention is to turn the output keys of the NFCT plugin compatible to the former one, and also add a configuration option to control whether to propagate one dataset per flow or two (as it was before).

Because the NFCT-related changes depend on a patchlet to libnetfilter-conntrack which might actually not be applied, I'll suggest to convert the code base to libnl sooner. Any objections?

Any feedback welcome.

/holger