Skip to content

async_tx: fix dependency handling and related cleanups

Dan Williams lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4async_tx: checkpatch says s/__FUNCTION__/__func__/gcrypto/async_tx/async_memcpy.c crypto/async_tx/async_memset.c crypto/async_tx/async_tx.c +1 more+15 -150 replies
2/4async_tx: fix multiple dependency submissioncrypto/async_tx/async_tx.c drivers/dma/dmaengine.c drivers/dma/iop-adma.c +1 more+170 -471 reply
3/4async_tx: kill ->device_dependency_addeddrivers/dma/dmaengine.c drivers/dma/ioat_dma.c drivers/dma/iop-adma.c +1 more+0 -221 reply
4/4iop-adma: remove the workaround for missed interrupts on iop3xxdrivers/dma/iop-adma.c include/asm-arm/arch-iop13xx/adma.h include/asm-arm/hardware/iop3xx-adma.h +1 more+0 -200 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchShannon Nelson
1/4
2/4A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] async_tx: fix dependency handling and related cleanups

Injecting channel-switch-interrupts has been broken for a while now. It has not been a problem in practice because the only in-tree driver that relied on this functionality was the iop3xx version of iop-adma, and it had a bug-masking local workaround. Three side benefits arise from this fix:

1/ dma_async_tx_descriptor sheds two list_heads
2/ Locking is made sane in that dma drivers no longer need to directly
touch dma_async_tx_descriptor.lock
3/ dma_device.device_dependency_added is no longer needed

Testing shows that iop-adma now gets by without the 'watchdog' workaround.

---

Dan Williams (4):
iop-adma: remove the workaround for missed interrupts on iop3xx
async_tx: kill ->device_dependency_added
async_tx: fix multiple dependency submission
async_tx: checkpatch says s/__FUNCTION__/__func__/g

 crypto/async_tx/async_memcpy.c         |    6 -
 crypto/async_tx/async_memset.c         |    6 -
 crypto/async_tx/async_tx.c             |  203 ++++++++++++++++++++++++++------
 crypto/async_tx/async_xor.c            |   12 +-
 drivers/dma/dmaengine.c                |    3 
 drivers/dma/ioat_dma.c                 |   12 --
 drivers/dma/iop-adma.c                 |   21 +--
 include/asm-arm/arch-iop13xx/adma.h    |    5 -
 include/asm-arm/hardware/iop3xx-adma.h |    8 -
 include/asm-arm/hardware/iop_adma.h    |    2 
 include/linux/dmaengine.h              |   11 --
 11 files changed, 185 insertions(+), 104 deletions(-)
Signature · 1 line
Dan