Skip to content

Remove sa_hash_xxx:series short description

Yi Zou linux-scsi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4hash for fc_remote_port: do not use sa_hash_xxxdrivers/scsi/ofc/include/fc_remote_port.h drivers/scsi/ofc/libfc/fc_remote_port.c drivers/scsi/ofc/libfc/fc_virt_fab_impl.h+146 -1860 replies
2/4hash for fc_sess: do not use sa_hash_xxxdrivers/scsi/ofc/include/fc_sess.h drivers/scsi/ofc/libfc/fc_sess.c drivers/scsi/ofc/libfc/fc_sess_impl.h +1 more+143 -790 replies
3/4remove hash table for fc_local_portdrivers/scsi/ofc/include/fc_local_port.h drivers/scsi/ofc/libfc/fc_local_port.c drivers/scsi/ofc/libfc/fc_local_port_impl.h +2 more+9 -980 replies
4/4remove sa_hash_kern.c/sa_hash.hdrivers/scsi/ofc/include/sa_hash.h drivers/scsi/ofc/libfc/fc_exch.c drivers/scsi/ofc/libsa/Makefile +1 more+1 -2100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] [FCoE] Remove sa_hash_xxx:series short description

The following series remove use of all sa_hash_xxx in hash table operations for fc_local_port, fc_remote_port, and fc_sess. sa_hash_kern.c and sa_hash.h are removed. All abstraction using sa_hash_xxx are removed and replaced by using hlist_head, hlist_node directly. Hash functions are in their own module now for fc_remote_port and fc_sess.

For fc_local_port, the hash is completely removed since there is always going to be just one fc_local_port per openfc/fcoe. For fc_remote_port, the hash by wwpn is removed with hash by remote port FCID already there. Hash entry counters are removed as they are used only in debugging/printting routines. All debugging/testing functions, e.g. hash table iterate, print, are removed as well.

Note that fc_virt_fab struct is still the place holder for the hash tables, which eventually will be in fcs_state struct once fc_virt_fab is merged with the fcs_state struct.

---

Yi Zou (4):
[FCoE] 4. remove sa_hash_kern.c/sa_hash.h [FCoE] 3. remove hash table for fc_local_port [FCoE] 2. hash for fc_sess: do not use sa_hash_xxx [FCoE] 1. hash for fc_remote_port: do not use sa_hash_xxx

 drivers/scsi/ofc/include/fc_local_port.h    |    6 
 drivers/scsi/ofc/include/fc_remote_port.h   |    4 
 drivers/scsi/ofc/include/fc_sess.h          |    3 
 drivers/scsi/ofc/include/sa_hash.h          |   65 -----
 drivers/scsi/ofc/libfc/fc_exch.c            |    1 
 drivers/scsi/ofc/libfc/fc_local_port.c      |   85 -------
 drivers/scsi/ofc/libfc/fc_local_port_impl.h |    4 
 drivers/scsi/ofc/libfc/fc_remote_port.c     |  325 ++++++++++++---------------
 drivers/scsi/ofc/libfc/fc_sess.c            |  214 +++++++++++-------
 drivers/scsi/ofc/libfc/fc_sess_impl.h       |    3 
 drivers/scsi/ofc/libfc/fc_virt_fab.c        |    5 
 drivers/scsi/ofc/libfc/fc_virt_fab_impl.h   |   10 -
 drivers/scsi/ofc/libsa/Makefile             |    4 
 drivers/scsi/ofc/libsa/sa_hash_kern.c       |  141 ------------
 14 files changed, 298 insertions(+), 572 deletions(-)
 delete mode 100644 drivers/scsi/ofc/include/sa_hash.h
 delete mode 100644 drivers/scsi/ofc/libsa/sa_hash_kern.c
Signature · 1 line
Yi Zou <[email protected]>