Skip to content

Page cache: Replace PAGE_CACHE_xx with inline functions V4

Christoph Lameter linux-fsdevel linux-mm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 2 repliesIn review

V2->V4 from the cover letter

- Rediff to upstream. Surprisingly no rejects at all so it seems that all of the pagecache patches that were in mm were merged. Just had to refresh the patches.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18Define functions for page cache handlinginclude/linux/pagemap.h+49 -02 replies
2/18Use page_cache_xxx functions in mm/filemap.cmm/filemap.c+46 -450 replies
3/18Use page_cache_xxx in mm/page-writeback.cmm/page-writeback.c+3 -30 replies
4/18Use page_cache_xxx in mm/truncate.cmm/truncate.c+18 -170 replies
5/18Use page_cache_xxx in mm/rmap.cmm/rmap.c+19 -40 replies
6/18Use page_cache_xxx in mm/filemap_xip.cmm/filemap_xip.c+14 -140 replies
7/18Use page_cache_xxx in mm/migrate.cmm/migrate.c+2 -10 replies
8/18Use page_cache_xxx in fs/libfs.cfs/libfs.c+7 -50 replies
9/18Use page_cache_xxx in fs/syncfs/sync.c+4 -40 replies
10/18Use page_cache_xxx in fs/buffer.cfs/buffer.c+65 -470 replies
11/18Use page_cache_xxx in mm/mpage.cfs/mpage.c+16 -120 replies
12/18Use page_cache_xxx in mm/fadvise.cmm/fadvise.c+4 -40 replies
13/18Use page_cache_xxx in fs/splice.cfs/splice.c+14 -130 replies
14/18Use page_cache_xxx in ext2fs/ext2/dir.c+23 -180 replies
15/18Use page_cache_xxx in fs/ext3fs/ext3/dir.c fs/ext3/inode.c+22 -200 replies
16/18Use page_cache_xxx in fs/ext4fs/ext4/dir.c fs/ext4/inode.c+19 -180 replies
17/18Use page_cache_xxx in fs/reiserfsfs/reiserfs/file.c fs/reiserfs/inode.c fs/reiserfs/ioctl.c +3 more+42 -300 replies
18/18Use page_cache_xxx for fs/xfsfs/xfs/linux-2.6/xfs_aops.c fs/xfs/linux-2.6/xfs_lrw.c+32 -300 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchDave Chinner
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V4

This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls.

The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is required if we want to support large block sizes in filesystems and block devices.

Patchset against upstream as of today (2.6.25-rc2)

Patchset can be pulled from

git://git.kernel.org/pub/scm/linux/kernel/git/christoph/vm.git pagecache-inline

V2->V4:
- Rediff to upstream. Surprisingly no rejects at all so it seems that all of the pagecache patches that were in mm were merged. Just had to refresh the patches.

V2->V3:
- Audit to check that uses of page->mapping are valid. Improve a couple of places. Make it clearer how the mappings are determined and handled (see the comments of each patch for detailed descriptions).
- Use a consistent method to determine the mapping if a function already does determine the inode via page->mapping->host.

V1->V2:
- Review by Dave Chinner. Multiple improvements and fixes.
- Review by Fengguand Wu with more improvements.

--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Read the cover letter in its thread