Skip to content

mac80211 sta info and related changes

Johannes Berg linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8mac80211: clarify use of TX status/RX callbacksinclude/net/mac80211.h+34 -30 replies
2/8mac80211: safely free beacon in ieee80211_if_reinitnet/mac80211/ieee80211_iface.c+5 -10 replies
3/8mac80211: split ieee80211_key_allocnet/mac80211/cfg.c net/mac80211/ieee80211_ioctl.c net/mac80211/ieee80211_key.h +1 more+87 -600 replies
4/8mac80211: RCU-ify STA info structure accessdrivers/net/wireless/iwlwifi/iwl-3945-rs.c drivers/net/wireless/iwlwifi/iwl-4965-rs.c net/mac80211/cfg.c +17 more+612 -3633 replies
5/8mac80211: split ieee80211_txrx_datanet/mac80211/ieee80211_i.h net/mac80211/rx.c net/mac80211/tx.c +5 more+313 -3040 replies
6/8mac80211: split sta_info_addnet/mac80211/cfg.c net/mac80211/ieee80211.c net/mac80211/ieee80211_sta.c +2 more+129 -570 replies
7/8mac80211: remove STA infos last_ack stuffnet/mac80211/debugfs_sta.c net/mac80211/rc80211_pid_algo.c net/mac80211/rc80211_simple.c +1 more+0 -390 replies
8/8mac80211: clean up sta_info and document lockingnet/mac80211/debugfs_sta.c net/mac80211/sta_info.h+76 -510 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchReinette Chatre
1/8
2/8
3/8
4/8T-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] mac80211 sta info and related changes

This patch series contains a few loosely related changes in mac80211 I did over the past few days:

* clarify use of TX status/RX callbacks
as per my previous mail, the irqsafe/non-irq-safe stuff

* safely free beacon in ieee80211_if_reinit
This is necessary for reentrancy reasons with ieee80211_beacon_get()

* split ieee80211_key_alloc
Preparation for RCU-ifying STA info, split key allocation into allocation and insertion

* RCU-ify STA info structure access
Remove STA refcount and instead protect them by RCU

* split ieee80211_txrx_data
Mostly unrelated, split up txrx_data and flags into one struct for TX and one for RX

* split sta_info_add
Split sta_info_add into _alloc and _link to resolve a few races and allow GFP_KERNEL allocations in many cases (which was removed by the RCU-ification patch)

* remove STA info's last_ack stuff
Remove some unused stats members

* clean up sta_info and document locking
Document and clean up the definition of struct sta_info and document the locking (deficiencies)

I'd like to have somebody else look over these but I'm confident that the changes do not, at least, introduce regressions.

johannes