Skip to content

: 2.6.24 regression fixes

Patrick McHardy netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3: nfnetlink_queue: fix SKB_LINEAR_ASSERT when mangling packet datanet/ipv4/netfilter/ip_queue.c net/ipv6/netfilter/ip6_queue.c net/netfilter/nfnetlink_queue.c+19 -131 reply
2/3: Fix incorrect use of skb_make_writablenet/bridge/netfilter/ebt_dnat.c net/bridge/netfilter/ebt_redirect.c net/bridge/netfilter/ebt_snat.c +1 more+4 -40 replies
3/3: fix ebtable targets returnnet/bridge/netfilter/ebt_dnat.c net/bridge/netfilter/ebt_redirect.c net/bridge/netfilter/ebt_snat.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NETFILTER -stable 00/03]: 2.6.24 regression fixes

These patches fix some netfilter regressions in 2.6.24 introduced by the removal of double skb pointers:

- a BUG when enlarging packets queued to userspace
- inverted error checking of skb_make_writable in bridge netfilter
- use of incorrect return codes after skb_make_writable errors in bridge netfilter

Please apply, thanks.

 net/bridge/netfilter/ebt_dnat.c     |    4 ++--
 net/bridge/netfilter/ebt_redirect.c |    4 ++--
 net/bridge/netfilter/ebt_snat.c     |    4 ++--
 net/ipv4/netfilter/arpt_mangle.c    |    2 +-
 net/ipv4/netfilter/ip_queue.c       |   12 +++++++-----
 net/ipv6/netfilter/ip6_queue.c      |   10 ++++++----
 net/netfilter/nfnetlink_queue.c     |   10 ++++++----
 7 files changed, 26 insertions(+), 20 deletions(-)

Patrick McHardy (3):
[NETFILTER]: nfnetlink_queue: fix SKB_LINEAR_ASSERT when mangling packet data [NETFILTER]: Fix incorrect use of skb_make_writable
[NETFILTER]: fix ebtable targets return