Skip to content

LSM-neutral Audit (SELinux audit separation)

Ahmed S. Darwish linux-audit lkml 2 versions – In review

Get series with b4
b4 am 20080301194752.GA19636@ubuntu

Versions newest first · linked by author and title

  1. v2 Latest9 patches 21 repliesIn review
  2. v14 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9LSM: Introduce inode_getsecid and ipc_getsecid hooksinclude/linux/security.h security/dummy.c security/security.c+54 -22 replies
2/9SELinux: setup new inode/ipc getsecid hookssecurity/selinux/hooks.c+17 -22 replies
3/9Audit: use new LSM hooks instead of SELinux exportskernel/audit.c kernel/auditfilter.c kernel/auditsc.c+43 -372 replies
4/9Netlink: Use generic LSM hooknet/netlink/af_netlink.c+1 -23 replies
5/9SELinux: remove redundant exportsinclude/linux/selinux.h security/selinux/exports.c+0 -1042 replies
6/9LSM/Audit: Introduce generic Audit LSM hooksinclude/linux/security.h security/dummy.c security/security.c+127 -12 replies
7/9Audit: internally use the new LSM audit hookskernel/audit.c kernel/auditfilter.c kernel/auditsc.c+22 -555 replies
8/9SELinux: use new audit hooks, remove redundant exportsinclude/linux/audit.h include/linux/selinux.h kernel/audit.h +3 more+136 -1081 reply
9/9Audit: Final renamings and cleanupinclude/linux/audit.h kernel/auditfilter.c kernel/auditsc.c+28 -281 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJames MorrisDavid S. MillerPaul Moore
1/9A-b R-b
2/9A-b R-b
3/9A-b R-b
4/9A-b A-b R-b
5/9A-b R-b
6/9A-b R-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH-v2 -mm 0/9] LSM-neutral Audit (SELinux audit separation)

Hi everybody,

A series of 9 patches to let Audit be LSM netural. This is done for proper future audit<->SMACK integration which will also be useful for any future LSM.

Basically, patches add below new LSM hooks:

1- secid extraction:
inode_getsecid(inode, secid)
ipc_getsecid(ipcp, secid)

2- LSM-specific Audit rules manipulation:
audit_rule_init(field, op, rulestr, lsmrule)
audit_rule_known(krule)
audit_rule_match(secid, field, op, rule, actx)
audit_rule_free(rule)

and remove ,now redundant, equivalent SELinux exported interfaces.

Initial work and idea by: Casey Schaufler <[email protected]> Thanks to Paul Moore <[email protected]> for his deep review of first version.

 include/linux/audit.h            |   29 ++++++++
 include/linux/security.h         |  102 +++++++++++++++++++++++++++++
 include/linux/selinux.h          |  134 ---------------------------------------
 kernel/audit.c                   |   24 ++----
 kernel/audit.h                   |   25 -------
 kernel/auditfilter.c             |   99 ++++++++++------------------
 kernel/auditsc.c                 |   74 +++++++++++----------
 net/netlink/af_netlink.c         |    3 +-
 security/dummy.c                 |   47 +++++++++++++
 security/security.c              |   35 ++++++++++
 security/selinux/exports.c       |   42 ------------
 security/selinux/hooks.c         |   27 +++++++
 security/selinux/include/audit.h |   65 ++++++++++++++++++
 security/selinux/ss/services.c   |   45 +++++++++----
 14 files changed, 420 insertions(+), 331 deletions(-)

Regards,

Signature · 5 lines
"Better to light a candle, than curse the darkness"

Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com