Skip to content

: Netfilter fixes

Patrick McHardy netfilter-devel 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5: nf_conntrack: fix smp_processor_id() in preemptible code warningnet/netfilter/nf_conntrack_core.c+12 -31 reply
2/5: xt_conntrack: fix missing boolean clampingnet/netfilter/xt_conntrack.c+1 -11 reply
3/5: xt_conntrack: fix IPv4 address comparisonnet/netfilter/xt_conntrack.c+1 -11 reply
4/5: nf_nat: always select same SNAT source for same hostnet/ipv4/netfilter/nf_nat_core.c+7 -43 replies
5/5: Fix NF_QUEUE_NR() parenthesisinclude/linux/netfilter.h+1 -11 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchTilman SchmidtChristian CasteydeDavid Lau
1/5T-b T-b
2/5
3/5
4/5T-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [NETFILTER 00/05]: Netfilter fixes

Hi Dave,

these patches for 2.6.25 fix a couple of netfilter bugs: the smp_processor_id() warning when using preemptible RCU reported by multiple people, address and state matching in the new xt_conntrack revision, and improper use of parenthesis in the NF_QUEUE_NR macro.

Additionally there is a patch to make the NAT core behave similar to the recently removed SAME target for SNAT, which fixes problems when accesing certain multihomed sites.

Please apply, thanks.

 include/linux/netfilter.h         |    2 +-
 net/ipv4/netfilter/nf_nat_core.c  |   11 +++++++----
 net/netfilter/nf_conntrack_core.c |   15 ++++++++++++---
 net/netfilter/xt_conntrack.c      |    4 ++--
 4 files changed, 22 insertions(+), 10 deletions(-)

Jan Engelhardt (2):
[NETFILTER]: xt_conntrack: fix missing boolean clamping [NETFILTER]: xt_conntrack: fix IPv4 address comparison

Patrick McHardy (3):
[NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code warning [NETFILTER]: nf_nat: always select same SNAT source for same host [NETFILTER]: Fix NF_QUEUE_NR() parenthesis