RFC: PCI: consolidate pcibios_enable_resources() implementations, v2
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 12 repliesIn review
Changes between v1 and v2 from the cover letter
- Moved ARM bridge enable to new platform_pci_enable_device(), called by pcibios_enable_device()
- Moved PA-RISC SERR & PERR enable to new platform_pci_enable_device(), called by pcibios_enable_device()
- In the generic pcibios_enable_resources(), adopted powerpc resource
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | PCI: split pcibios_enable_resources() out of pcibios_enable_device()arch/ arch/ arch/ +4 more | +46 | 0 replies | |
| 2/6 | ppc: make pcibios_enable_device() use pcibios_enable_resources()arch/ | +2 | 0 replies | |
| 3/6 | xtensa: make pcibios_enable_device() use pcibios_enable_resources()arch/ | +1 | 0 replies | |
| 4/6 | ARM: move bridge enable out of pcibios_enable_resources()arch/ | +26 | 5 replies | |
| 5/6 | PARISC: move PERR & SERR enables out of pcibios_enable_resources()arch/ | +31 | 3 replies | |
| 6/6 | PCI: consolidate several pcibios_enable_resources() implementationsarch/ arch/ arch/ +15 more | +45 | 3 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Benjamin Herrenschmidt | Bjorn Helgaas | Grant Grundler | David Howells | Russell King |
|---|---|---|---|---|---|
| 1/6 | A-b | ||||
| 2/6 | A-b | ||||
| 3/6 | |||||
| 4/6 | A-b | ||||
| 5/6 | Ack-By | ||||
| 6/6 | Not-Yet-Signed-off-by | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch series consolidates most of them to use the x86 version.
Changes between v1 and v2:
- Moved ARM bridge enable to new platform_pci_enable_device(), called by pcibios_enable_device()
- Moved PA-RISC SERR & PERR enable to new platform_pci_enable_device(), called by pcibios_enable_device()
- In the generic pcibios_enable_resources(), adopted powerpc resource
collision detection (check for (!r->parent) instead of
(!r->start && r->end)) - In the generic pcibios_enable_resources(), added a little more detail to the resource collision error message
- Moved consolidated pcibios_enable_resources() from bios.c to setup-res.c
Thanks for the comments on the first version. I think this addresses all of them.
Any other comments would be welcome.
Bjorn