Skip to content

RFC: PCI: consolidate pcibios_enable_resources() implementations, v2

Bjorn Helgaas linux-arch linux-parisc linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Changes between v1 and v2 from the cover letter

- Moved ARM bridge enable to new platform_pci_enable_device(), called by pcibios_enable_device()

- Moved PA-RISC SERR & PERR enable to new platform_pci_enable_device(), called by pcibios_enable_device()

- In the generic pcibios_enable_resources(), adopted powerpc resource

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6PCI: split pcibios_enable_resources() out of pcibios_enable_device()arch/alpha/kernel/pci.c arch/arm/kernel/bios32.c arch/parisc/kernel/pci.c +4 more+46 -120 replies
2/6ppc: make pcibios_enable_device() use pcibios_enable_resources()arch/ppc/kernel/pci.c+2 -240 replies
3/6xtensa: make pcibios_enable_device() use pcibios_enable_resources()arch/xtensa/kernel/pci.c+1 -250 replies
4/6ARM: move bridge enable out of pcibios_enable_resources()arch/arm/kernel/bios32.c+26 -45 replies
5/6PARISC: move PERR & SERR enables out of pcibios_enable_resources()arch/parisc/kernel/pci.c+31 -63 replies
6/6PCI: consolidate several pcibios_enable_resources() implementationsarch/alpha/kernel/pci.c arch/arm/kernel/bios32.c arch/cris/arch-v32/drivers/pci/bios.c +15 more+45 -5073 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchBenjamin HerrenschmidtBjorn HelgaasGrant GrundlerDavid HowellsRussell King
1/6A-b
2/6A-b
3/6
4/6A-b
5/6Ack-By
6/6Not-Yet-Signed-off-by A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2

There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch series consolidates most of them to use the x86 version.

Changes between v1 and v2:

- Moved ARM bridge enable to new platform_pci_enable_device(), called by pcibios_enable_device()

- Moved PA-RISC SERR & PERR enable to new platform_pci_enable_device(), called by pcibios_enable_device()

- In the generic pcibios_enable_resources(), adopted powerpc resource

    collision detection (check for (!r->parent) instead of
    (!r->start && r->end))

- In the generic pcibios_enable_resources(), added a little more detail to the resource collision error message

- Moved consolidated pcibios_enable_resources() from bios.c to setup-res.c

Thanks for the comments on the first version. I think this addresses all of them.

Any other comments would be welcome.

Bjorn