Skip to content

Server side automatic tag following

Shawn O. Pearce git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 52 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Rename imap-send's internal info/warn functions.imap-send.c+12 -120 replies
1/3Remove unnecessary argc parameter from run_command_v.builtin-push.c receive-pack.c run-command.c +1 more+9 -90 replies
1/3Don't save the commit buffer in git-describe.describe.c+1 -00 replies
1/3Cleanup variables in cat-filebuiltin-cat-file.c+18 -120 replies
1/3Lazily open pack index files on demandbuiltin-count-objects.c cache.h pack-check.c +2 more+49 -621 replies
1/3Simplify index access condition in count-objects, pack-redundantbuiltin-count-objects.c pack-redundant.c+2 -20 replies
1/3Teach update-paranoid how to store ACLs organized by groupscontrib/hooks/update-paranoid+44 -160 replies
1/3Allow builtin-fetch to work on a detached HEADbuiltin-fetch.c+2 -10 replies
1/3Cleanup style nit of 'x == NULL' in remote.cremote.c+3 -30 replies
1/3run-command: Support sending stderr to /dev/nullrun-command.c run-command.h+5 -20 replies
1/3Don't allow git-describe failures to go unnoticed in t6120t/t6120-describe.sh+3 -10 replies
1/3git-pack-objects: Automatically pack annotated tags if object was packedDocumentation/git-pack-objects.txt builtin-pack-objects.c t/t5305-autofollow-tag.sh+111 -27 replies
1/3Don't diff empty tree on branch creation in paranoid update hookcontrib/hooks/update-paranoid+6 -80 replies
1/3Remove unused remote_prefix member in builtin-remotebuiltin-remote.c+0 -30 replies
1/3http-backend: Fix symbol clash on AIX 5.3http-backend.c+5 -50 replies
2/3Introduce a global level warn() function.git-compat-util.h usage.c+21 -00 replies
2/3Redirect update hook stdout to stderr.receive-pack.c run-command.c run-command.h+30 -70 replies
2/3Make git-describe a builtin.Makefile builtin-describe.c builtin.h +2 more+180 -1770 replies
2/3Improve argument parsing in cat-filebuiltin-cat-file.c+14 -130 replies
2/3Micro-optimize prepare_alt_odbsha1_file.c+3 -20 replies
2/3Ensure the pack index is opened before accessbuiltin-fsck.c+4 -10 replies
2/3Teach the update-paranoid to look at file differencescontrib/hooks/update-paranoid+105 -70 replies
2/3Don't configure remote "." to fetch everything to itselfremote.c+0 -40 replies
2/3Cleanup unnecessary break in remote.cremote.c+3 -60 replies
2/3rev-list: Introduce --no-output to avoid /dev/null redirectsDocumentation/git-rev-list.txt builtin-rev-list.c+31 -45 replies
2/3Test for packed tags in git-describe outputt/t6120-describe.sh+3 -00 replies
2/3Teach fetch-pack/upload-pack about --auto-follow-tagsDocumentation/git-fetch-pack.txt builtin-fetch-pack.c fetch-pack.h +1 more+24 -60 replies
2/3Don't load missing ACL files in paranoid update hookcontrib/hooks/update-paranoid+1 -00 replies
2/3Make "git-remote prune" delete refs according to fetch specsbuiltin-remote.c t/t5505-remote.sh+20 -190 replies
2/3t5551-http-fetch: Work around some libcurl versionst/t5551-http-fetch.sh+4 -41 reply
3/3Don't crash during repack of a reflog with pruned commits.revision.c+19 -107 replies
3/3Use /dev/null for update hook stdin.receive-pack.c run-command.c run-command.h+8 -61 reply
3/3Chose better tag names in git-describe after merges.builtin-describe.c+67 -110 replies
3/3Teach cat-file a --quiet optionDocumentation/git-cat-file.txt builtin-cat-file.c+24 -65 replies
3/3Attempt to delay prepare_alt_odb during get_sha1sha1_name.c+1 -10 replies
3/3Style nit - don't put space after function namessha1_file.c+1 -10 replies
3/3Use the empty tree for base diff in paranoid-update on new branchescontrib/hooks/update-paranoid+21 -100 replies
3/3Remove more debugging from builtin-fetchbuiltin-fetch.c+0 -20 replies
3/3Prevent send-pack from segfaulting when a branch doesn't matchremote.c+4 -10 replies
3/3git-fetch: avoid local fetching from alternate (again)transport.c+65 -34 replies
3/3Add git-describe test for "verify annotated tag names on output"t/t6120-describe.sh+16 -10 replies
3/3Teach git-fetch to exploit server side automatic tag followingbuiltin-fetch.c t/t5503-tagfollow.sh transport.c +1 more+37 -00 replies
3/3Ignore no-op changes in paranoid update hookcontrib/hooks/update-paranoid+1 -00 replies
3/3Make "git-remote rm" delete refs acccording to fetch specsbuiltin-remote.c+6 -56 replies
3/3t5551-http-fetch: Work around broken Accept header in libcurlt/t5551-http-fetch.sh+3 -01 reply

Reviews trailers per patch

None of the 45 patches has a Reviewed-by or Acked-by.

PatchTarmigan
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
1/3
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
2/3Tested-with-modifications-by
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Server side automatic tag following

As promised earlier, this series adds automatic tag following on the server side, allowing git-fetch to grab tags over a single connection rather than opening a secondary one for the tags we cannot get via my 'sp/fetch-optim' branch.

  1)  git-pack-objects: Automatically pack annotated tags if object was packed
  2)  Teach fetch-pack/upload-pack about --auto-follow-tags
  3)  Teach git-fetch to exploit server side automatic tag following
 Documentation/git-fetch-pack.txt   |    8 +++-
 Documentation/git-pack-objects.txt |    5 ++
 builtin-fetch-pack.c               |    9 +++-
 builtin-fetch.c                    |    3 +
 builtin-pack-objects.c             |   24 +++++++++-
 fetch-pack.h                       |    3 +-
 t/t5305-autofollow-tag.sh          |   84 ++++++++++++++++++++++++++++++++++++
 t/t5503-tagfollow.sh               |   26 +++++++++++
 transport.c                        |    5 ++
 transport.h                        |    3 +
 upload-pack.c                      |   10 +++-
 11 files changed, 172 insertions(+), 8 deletions(-)

We may still want to support multiple request/pack pairs on a single connection, but I think that's more work than this is and may not offer a worthwhile pay-off. Usually the client knows what branches it wants when it connects, and if it wants tag data. That's all we need to know on the server to generate an optimal packfile, and said packfile is the only thing the client needs to update itself.

The multiple request/pack pairs is actually better implemented for users like X.org where you want to update many repositories over a single SSH connection. For that we need git-fetch to multiplex over multiple repositories, not just git-upload-pack.

Signature · 1 line
Shawn.