Skip to content

New driver "sfc" for Solarstorm SFC4000 controller (try #9)

Ben Hutchings netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/efx.c drivers/net/sfc/efx.h+2279 -00 replies
2/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/rx.c drivers/net/sfc/rx.h drivers/net/sfc/tx.c +1 more+1380 -00 replies
3/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/bitfield.h drivers/net/sfc/enum.h drivers/net/sfc/net_driver.h+1441 -00 replies
4/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/falcon.c drivers/net/sfc/falcon.h+2856 -00 replies
5/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/falcon_hwdefs.h drivers/net/sfc/falcon_io.h drivers/net/sfc/spi.h +1 more+1484 -00 replies
6/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/ethtool.c drivers/net/sfc/ethtool.h drivers/net/sfc/mdio_10g.c +1 more+1002 -00 replies
7/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)drivers/net/sfc/boards.c drivers/net/sfc/boards.h drivers/net/sfc/falcon_xmac.c +9 more+2360 -00 replies
8/8New driver "sfc" for Solarstorm SFC4000 controller (try #9)MAINTAINERS drivers/net/Kconfig drivers/net/Makefile +2 more+27 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] New driver "sfc" for Solarstorm SFC4000 controller (try #9)

This is a resubmission of a new driver for Solarflare network controllers.

The driver supports the 10Xpress PHY and XFP modules on our reference designs SFE4001 and SFE4002 and the SMC models SMC10GPCIe-XFP and SMC10GPCIe-10BT.

The previous patches began with:
http://marc.info/?l=linux-netdev&m=120528862826282&w=2

Some explanation of the driver structure was posted in:
http://marc.info/?l=linux-netdev&m=119999015817920&w=2

Since the last submission we have addressed the review comments:
- Remove local unused flags variables.
- Removed bogus uses of __attribute__ ((unused)).
- Removed conditional use of topology_core_siblings().
- Moved net-dev allocation and freeing from efx_{init,fini}_napi() to efx_pci_{probe,remove}() since we only have one port per PCI function. Moved net-dev initialisation and association from efx_init_napi() to appropriate functions. Removed now-obsolete test that efx->net_dev is non-null.
- Simplified Makefile.

We have also made a number of bug fixes:
- Always reconfigure MAC in efx_start_port(); this avoids potential missed signalling of net carrier.
- Moved call to falcon_update_nic_stats() into efx_net_stats() since it now requires NIC stats as well.
- Remove useless call to efx_reconfigure_port() from efx_ioctl().
- When fini'ing the tx queue, don't complain about completing empty descriptors. Whilst here make skipping tx descriptors a proper error, and perform an invisible reset.
- Don't propagate link state changes whilst the port is down.
- Fixed failure path for efx_probe_all() to call efx_remove_nic() if necessary.
- Fixed efx_ethtool_set_pauseparam() to propagate result of efx_mac_operations::set_pause.

We also did some cleanup and simplification:
- Removed declaration of removed function falcon_debugfs_read_hardware_desc().
- Removed unused definitions of EFX_WORD, EFX_DWORD, EFX_OWORD. Removed definition of EFX_BYTE and replaced with literal 1 in sfe4001.c.
- Removed unused inline function efx_is_over_4gb().
- Changed return type of efx_probe_interrupts() and efx_select_used() to void, as they can never fail. Simplified efx_probe_nic() accordingly.
- Renamed FALCON_BUF_ALIGN to FALCON_BUF_SIZE (it is both size and alignment). Replaced literal 4096 in falcon_alloc_special_buffer() with FALCON_BUF_SIZE. Made use of kernel ALIGN() macro in falcon_alloc_special_buffer().
- Corrected first comment in i2c-direct.c - we don't use I2C for EEPROM access on Falcon.
- Removed name format macros only used by ethtool self-tests and debugfs.
- Removed SPI-related members from efx_nic, only needed for MTD driver.
- Remove the net_dev_registered flag, replacing it with checks on the net_dev->flags field. netif_running() is implicitly false when NET_DEV_REGISTERED()==0, so remove some spurious checks.
- Since we always call efx_reconfigure_port() in efx_start_port(), then always drain the port in efx_stop_all(). This removes an unneeded abstraction.

We hope the driver is now ready to be merged.

Ben.

Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.