Skip to content

Improvements to the lm85 driver

Jean Delvare lm-sensors 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10hwmon: (lm85) Fix function RANGE_TO_REG()drivers/hwmon/lm85.c+11 -140 replies
2/10hwmon: (lm85) Coding-style cleanupsdrivers/hwmon/lm85.c+224 -2172 replies
3/10hwmon: (lm85) Drop dead codeDocumentation/hwmon/lm85 drivers/hwmon/lm85.c+6 -869 replies
4/10hwmon: (lm85) Don't write back cacheddrivers/hwmon/lm85.c+6 -90 replies
5/10hwmon: (lm85) Misc cleanupsdrivers/hwmon/lm85.c+63 -760 replies
6/10hwmon: (lm85) Simplify devicedrivers/hwmon/lm85.c+18 -430 replies
7/10hwmon: (lm85) Rework the device detectiondrivers/hwmon/lm85.c+50 -700 replies
8/10hwmon: (lm85) Implement the standard PWMdrivers/hwmon/lm85.c+40 -500 replies
9/10hwmon: (lm85) Select the closest PWMdrivers/hwmon/lm85.c+12 -40 replies
10/10hwmon: (lm85) Support different PWMdrivers/hwmon/lm85.c+24 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [lm-sensors] [PATCH 00/10] Improvements to the lm85 driver

Hi all,

Here's a set of 10 incremental patches fixing, cleaning up and improving the lm85 hardware monitoring driver. My home server has an SMSC EMC6D102 chip so I needed the patches for myself, and I tested them on this machine.

The patches are:
bug fix: [PATCH 01/10] hwmon: (lm85) Fix function RANGE_TO_REG()
cleanup: [PATCH 02/10] hwmon: (lm85) Coding-style cleanups
cleanup: [PATCH 03/10] hwmon: (lm85) Drop dead code
bug fix: [PATCH 04/10] hwmon: (lm85) Don't write back cached values
cleanup: [PATCH 05/10] hwmon: (lm85) Misc cleanups
cleanup: [PATCH 06/10] hwmon: (lm85) Simplify device initialization function
cleanup: [PATCH 07/10] hwmon: (lm85) Rework the device detection
feature: [PATCH 08/10] hwmon: (lm85) Implement the standard PWM frequency interface
feature: [PATCH 09/10] hwmon: (lm85) Select the closest PWM frequency
feature: [PATCH 10/10] hwmon: (lm85) Support different PWM frequency tables

It is worth noting that this shrinks the binary size of the lm85 driver by 5.5%, and the source code size by 11%.

Comments, reviews and testing are of course welcome.

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors