Skip to content

NE2000: Fix regresssion introduced by e710185aae90 on non AX88796

Wolfgang Denk u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qemu-mips: Cleanup whiespaces, tab indentations, etc.+0 -03 replies
1/2qemu-mips: Cleanup whiespaces, tab indentations, etc.+0 -00 replies
2/2qemu-mips.h: Add CFI support+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot-Users] [PATCH 0/2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 7 lines
Quoted 5 lines

Move non-inlied functions into specific drivers file Set get_prom as weak

Coding Style Cleanup

Please split in two (3?) separate patches. Thanks.

We could separate the Coding style in an other patch but if possible i'll let it in the same patch.

Please split it up, because otherwise the changes are really difficult to see.

Quoted 2 lines

Seperate the moving of non-inlined functions and the setting of get_prom as weak is ine block to fix the regression

OK.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's a small world, but I wouldn't want to paint it.