Skip to content

scsi_dh: Move hardware handlers from dm to SCSI

Chandra Seetharaman dm-devel linux-scsi 1 version In review

Get series with b4
b4 am 20080501214941.27759.95121.sendpatchset@chandra-ubuntu

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10scsi_dh: add infrastructure for SCSI Device Handlersdrivers/scsi/Kconfig drivers/scsi/Makefile drivers/scsi/device_handler/Kconfig +8 more+283 -00 replies
2/10scsi_dh: add lsi rdac device handlerdrivers/scsi/device_handler/Kconfig drivers/scsi/device_handler/Makefile drivers/scsi/device_handler/scsi_dh_rdac.c+698 -00 replies
3/10scsi_dh: add hp sw device handlerdrivers/scsi/device_handler/Kconfig drivers/scsi/device_handler/Makefile drivers/scsi/device_handler/scsi_dh_hp_sw.c+211 -00 replies
4/10scsi_dh: add EMC Clariion device handlerdrivers/scsi/device_handler/Kconfig drivers/scsi/device_handler/Makefile drivers/scsi/device_handler/scsi_dh_emc.c+506 -00 replies
5/10scsi_dh: Use SCSI device handler in dm-multipathdrivers/md/Kconfig drivers/md/dm-mpath.c+81 -510 replies
6/10scsi_dh: Do not allow arguments for hardware handlersdrivers/md/dm-mpath.c+6 -22 replies
7/10scsi_dh: Add a single threaded workqueue for initializing pathsdrivers/md/dm-mpath.c+34 -70 replies
8/10scsi_dh: Remove dm_pg_init_completedrivers/md/dm-mpath.c+0 -410 replies
9/10scsi_dh: Remove hardware handlers from dmdrivers/md/Kconfig drivers/md/Makefile drivers/md/dm-emc.c +2 more+0 -13170 replies
10/10scsi_dh: Remove hardware handler infrastructure from dmdrivers/md/Makefile drivers/md/dm-hw-handler.c drivers/md/dm-hw-handler.h +1 more+1 -2780 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] scsi_dh: Move hardware handlers from dm to SCSI

Hello,

This is the latest version of the patchset that was posted on Apr 17:
http://marc.info/?l=linux-scsi&m=120847097122545&w=2

Following are the changes made since last post:
Based on Alasdair's comments:
- Split the dm-mpath patch into 4 patches to enhance readabilty
- Added comments to patch header and inline
- Added an interface scsi_dh_handler_exist() and used it to verify the availability of a hardware handler
- Do not accept arguments with the hardware handler parameter
- Make the workqueue single threaded, and change its name
- removed the usage of path_to_activate and used an existing field -renamed activate_passive_path to activate_path
- Bring back the pg_init_retries.
Others:
- Added additional devices to the device list
- removed few erroneous BUG assertions
- Fixed an erroneous return code from scsi_dh_rdac.c.

This patch set applies on 2.6.25-mm1.

This patch set has been tested on a DS4800.

Testing has been done earlier with the following storage devices:
- IBM DS4800 storage device for the lsi_rdac hardware handler
- HP storage device for the hp_sw hardware handler.
Thanks to Dave([email protected])
- EMC storage device for the EMC hardware handler.
Thanks to Arthur([email protected]) and Ronald([email protected])
In effect all hardware handlers are tested.

-------------------- Comment from Patch 01/10 --------------------- Some of the storage devices (that can be accessed through multiple paths), do need some special handling for
1. Activating the passive path of the storage access.
2. Decode and handle the special sense codes returned by the devices.
3. Handle the I/Os being sent to the passive path, especially during the device probe time.
when accessed through multiple paths.

As of today this special device handling is done at the dm-multipath layer using dm-handlers. That works well for (1); for (2) to be handled at dm layer, scsi sense information need to be exported from SCSI to dm-layer, which is not very attractive; (3) cannot be done at all at the dm layer.

Device handler has been moved to SCSI mainly to handle (2) and (3) properly.
----------------------

Thanks,

chandra