dev_open() and dev_close() require RTNL

Ben Hutchings linux-x25 netdev 1 version May 6, 2008 Applied

Status from this message: Applied, thanks Ben.

Get series with b4

b4 am [email protected]

Versions newest first

v1 Latest May 6, 20084 patches 9 repliesApplied

Patches in v1 Applied

#	Subject and files	Size	Replies
1/4	Added ASSERT_RTNL() to dev_open() and dev_close().`net/core/dev.c`	+4 -0	1 reply
2/4	qla3xxx: Hold RTNL while calling dev_close()`drivers/net/qla3xxx.c`	+2 -0	2 replies
3/4	sky2: Hold RTNL while calling dev_close()`drivers/net/sky2.c`	+2 -0	7 replies
4/4	Hold RTNL while calling dev_close()`drivers/net/wan/x25_asy.c`	+3 -0	3 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

Patch	David S. Miller
1/4
2/4	A-b
3/4
4/4	A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] dev_open() and dev_close() require RTNL

dev_open() and dev_close() clearly require the RTNL, but this isn't commented or asserted. The following series adds assertions and fixes three drivers that call dev_close() without holding the RTNL. The driver changes are only compile-tested.

Ben.

Signature · 2 lines

Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.

Read the cover letter in its thread