ide: generic ATAPI support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest40 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/40 | ide-scsi: fix race in idescsi_transfer_pc()drivers/ | +4 | 0 replies | |
| 2/40 | ide-scsi: fix DRQ checking for DMA transfers in idescsi_pc_intr()drivers/ | +8 | 0 replies | |
| 3/40 | ide-scsi: fix handling of DMA errors in idescsi_pc_intr()drivers/ | +5 | 0 replies | |
| 4/40 | ide-scsi: fix Interrupt Reason checking in idescsi_pc_intr()drivers/ | +11 | 2 replies | |
| 5/40 | ide-scsi: merge idescsi_input_buffers() and idescsi_output_buffers()drivers/ | +24 | 0 replies | |
| 6/40 | ide-scsi: remove superfluous BUG_ON() from idescsi_transfer_pc()drivers/ | +1 | 0 replies | |
| 7/40 | ide-scsi: add debug_log() macrodrivers/ | +25 | 0 replies | |
| 8/40 | ide-tape: idetape_pc_intr() should use local_irq_enable_in_hardirq()drivers/ | +1 | 0 replies | |
| 9/40 | ide-tape: remove superfluous error message from idetape_pc_intr()drivers/ | +0 | 0 replies | |
| 10/40 | ide-tape: remove superfluous warning message from idetape_issue_pc()drivers/ | +0 | 0 replies | |
| 11/40 | ide-tape: remove unneeded CONFIG_BLK_DEV_IDEDMA ifdefdrivers/ | +2 | 0 replies | |
| 12/40 | ide-tape: remove stale comments from idetape_pc_intr()drivers/ | +0 | 0 replies | |
| 13/40 | ide-tape: remove SIMULATE_ERRORS debug codedrivers/ | +0 | 0 replies | |
| 14/40 | ide-floppy: merge idefloppy_transfer_pc() and idefloppy_transfer_pc1()drivers/ | +17 | 4 replies | |
| 15/40 | ide-{floppy,tape,scsi}: log device name instead of driver namedrivers/ drivers/ drivers/ | +53 | 0 replies | |
| 16/40 | ide-tape: make idetape_retry_pc() voiddrivers/ | +5 | 0 replies | |
| 17/40 | ide-tape: merge callbacksdrivers/ | +64 | 0 replies | |
| 18/40 | ide-tape: make pc->idetape_callback voiddrivers/ include/ | +8 | 0 replies | |
| 19/40 | ide-floppy: merge callbacksdrivers/ | +24 | 0 replies | |
| 20/40 | ide-{floppy,tape}: merge pc->idefloppy_callback and pc->idetape_callbackdrivers/ drivers/ include/ | +9 | 0 replies | |
| 21/40 | ide-{floppy,tape}: PC_FLAG_DMA_RECOMMENDED -> PC_FLAG_DMA_OKdrivers/ drivers/ include/ | +10 | 0 replies | |
| 22/40 | ide-floppy: start DMA engine in idefloppy_transfer_pc1()drivers/ | +10 | 2 replies | |
| 23/40 | ide-tape: set PC_FLAG_DMA_IN_PROGRESS flag in idetape_transfer_pc()drivers/ | +6 | 0 replies | |
| 24/40 | ide-tape: factor out waiting for good ireason from idetape_transfer_pc()drivers/ | +23 | 0 replies | |
| 25/40 | ide: add PC_FLAG_ZIP_DRIVE pc flagdrivers/ include/ | +7 | 0 replies | |
| 26/40 | ide-{cd,floppy,tape}: remove checking for drive->scsidrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 27/40 | ide-scsi: set drive->scsi flag for devices handled by the driverdrivers/ | +5 | 0 replies | |
| 28/40 | ide: add ide_transfer_pc() helperdrivers/ drivers/ drivers/ +4 more | +85 | 0 replies | |
| 29/40 | ide-scsi: move idescsi_map_sg() call out from idescsi_issue_pc()drivers/ | +10 | 0 replies | |
| 30/40 | ide: add PC_FLAG_DRQ_INTERRUPT pc flagdrivers/ drivers/ drivers/ +1 more | +18 | 0 replies | |
| 31/40 | ide: add ide_issue_pc() helperdrivers/ drivers/ drivers/ +2 more | +60 | 0 replies | |
| 32/40 | ide-{floppy,tape}: move checking of ->failed_pc to ->callbackdrivers/ drivers/ | +6 | 0 replies | |
| 33/40 | ide-tape: factor out DSC handling from idetape_pc_intr()drivers/ | +13 | 0 replies | |
| 34/40 | ide-tape: add ide_tape_io_buffers() helperdrivers/ | +10 | 0 replies | |
| 35/40 | ide-tape: always log debug info in idetape_pc_intr() if debugging is enableddrivers/ | +10 | 0 replies | |
| 36/40 | ide-floppy: add more debugging to idefloppy_pc_intr()drivers/ | +8 | 0 replies | |
| 37/40 | ide-scsi: use pc->callbackdrivers/ | +22 | 0 replies | |
| 38/40 | ide-scsi: add more debugging to idescsi_pc_intr()drivers/ | +11 | 0 replies | |
| 39/40 | ide-{floppy,scsi}: read Status Register before stopping DMA enginedrivers/ drivers/ | +7 | 0 replies | |
| 40/40 | ide: add ide_pc_intr() helperdrivers/ drivers/ drivers/ +2 more | +195 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/40] ide: generic ATAPI support
Hi,
This patch series unifies ATAPI support present in ide-{floppy,tape,scsi} device drivers and moves it out to the core IDE code (new ide-atapi.c file).
In the process many bugs were shaken out and ~300 LOC were removed.
diffstat:
drivers/ide/Kconfig | 6 drivers/ide/Makefile | 1 drivers/ide/ide-atapi.c | 296 ++++++++++++++++++++++ drivers/ide/ide-cd.c | 5 drivers/ide/ide-floppy.c | 431 +++++++------------------------- drivers/ide/ide-tape.c | 630 ++++++++++++++--------------------------------- drivers/scsi/ide-scsi.c | 455 +++++++++++---------------------- include/linux/ide.h | 28 +- 8 files changed, 777 insertions(+), 1075 deletions(-)
Now, while this is a big step in the right direction there are still some things left on TODO for generic ATAPI support to be complete:
- convert ide-cd to use generic ATAPI code
- kill pc and rq stacks in ide-{floppy,tape}
- generic handling of REQUEST SENSE command
- generic handling of MODE SENSE command for ide-{floppy,tape}
- convert ide-{cd,floppy,tape} to use scatterlists for PIO transers (ala ide-scsi)
I know that Borislav is working on the first two items but other ones are free at the moment so if you feel brave you may give it a try :-).
PS I'll be travelling during this weekend and be rather busy with day job
so replies from me may be delayed a bit.
Thanks,
Bart