Skip to content

watchdog: Giant scrub

Alan Cox lkml 1 version In review

Get series with b4
b4 am 20080519124659.31722.51847.stgit@core

Versions newest first

  1. v1 Latest57 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/57Clean acquirewdt and check for BKL dependanciesdrivers/watchdog/acquirewdt.c+58 -610 replies
2/57clean up and check advantech watchdogdrivers/watchdog/advantechwdt.c+61 -720 replies
3/57ali: watchdog locking and styledrivers/watchdog/alim1535_wdt.c drivers/watchdog/alim7101_wdt.c+209 -2010 replies
4/57AR7 watchdogdrivers/watchdog/ar7_wdt.c+17 -120 replies
5/57atp watchdogdrivers/watchdog/at32ap700x_wdt.c+3 -40 replies
6/57at91: watchdog to unlocked_ioctldrivers/watchdog/at91rm9200_wdt.c+54 -540 replies
7/57cpu5_wdt: switch to unlocked_ioctldrivers/watchdog/cpu5wdt.c+70 -740 replies
8/57davinci_wdt: unlocked_ioctl and check lockingdrivers/watchdog/davinci_wdt.c+5 -60 replies
9/57ep93xx_wdt: unlocked_ioctldrivers/watchdog/ep93xx_wdt.c+9 -80 replies
10/57eurotechwdt: unlocked_ioctl, code lock check and tidydrivers/watchdog/eurotechwdt.c+36 -210 replies
11/57hpwdt: couple of include cleanupsdrivers/watchdog/hpwdt.c+2 -20 replies
12/57ib700wdt: clean up and switch to unlocked_ioctldrivers/watchdog/ib700wdt.c+52 -510 replies
13/57i6300esb: Style, unlocked_ioctl, cleanupdrivers/watchdog/i6300esb.c+167 -1750 replies
14/57ibmasr: coding style, locking verifydrivers/watchdog/ibmasr.c+87 -621 reply
15/57indydog: Clean up and tidydrivers/watchdog/indydog.c+62 -520 replies
16/57iop: watchdog switch to unlocked_ioctldrivers/watchdog/iop_wdt.c+24 -220 replies
17/57it8712f: unlocked_ioctldrivers/watchdog/it8712f_wdt.c+27 -500 replies
18/57iTCO: unlocked_ioctl, coding style and cleanupdrivers/watchdog/iTCO_vendor.h drivers/watchdog/iTCO_vendor_support.c drivers/watchdog/iTCO_wdt.c+188 -1747 replies
19/57bfin: watchdog cleanup and unlocked_ioctldrivers/watchdog/bfin_wdt.c+71 -760 replies
20/57booke watchdog: clean up and unlocked_ioctldrivers/watchdog/booke_wdt.c+30 -270 replies
21/57ixp2000_wdt: clean up and unlocked_ioctldrivers/watchdog/ixp2000_wdt.c+23 -270 replies
22/57ixp4xx_wdt: unlocked_ioctldrivers/watchdog/ixp4xx_wdt.c+17 -240 replies
23/57ks8695_wdt: clean up, coding style, unlocked_ioctldrivers/watchdog/ks8695_wdt.c+62 -570 replies
24/57machzwd: clean up, coding style, unlocked_ioctldrivers/watchdog/machzwd.c+40 -680 replies
25/57mixcomwd: coding style locking, unlocked_ioctldrivers/watchdog/mixcomwd.c+63 -700 replies
26/57mpc watchdog: clean up and lockingdrivers/watchdog/mpc5200_wdt.c drivers/watchdog/mpc83xx_wdt.c drivers/watchdog/mpc8xx_wdt.c+41 -350 replies
27/57mpcore watchdog: unlocked_ioctl and BKl workdrivers/watchdog/mpcore_wdt.c+32 -210 replies
28/57mtx-1_wdt: clean up, coding style, unlocked ioctldrivers/watchdog/mtx-1_wdt.c+52 -551 reply
29/57mv64x60_wdt: clean up and locking checksdrivers/watchdog/mv64x60_wdt.c+11 -90 replies
30/57omap_wdt: locking, unlocked_ioctl, tidydrivers/watchdog/omap_wdt.c+21 -140 replies
31/57pc87413_wdt: clean up, coding style, unlocked_ioctldrivers/watchdog/pc87413_wdt.c+87 -1240 replies
32/57pcwd: clean up, unlocked_ioctl usagedrivers/watchdog/pcwd.c+100 -790 replies
33/57pnx4008_wdt: unlocked_ioctl setupdrivers/watchdog/pnx4008_wdt.c+8 -100 replies
34/57rm9k_wdt: clean updrivers/watchdog/rm9k_wdt.c+12 -90 replies
35/57s3c2410: watchdog cleanup and switch to unlocked_ioctldrivers/watchdog/s3c2410_wdt.c+80 -680 replies
36/57sa1100_wdt: Switch to unlocked_ioctldrivers/watchdog/sa1100_wdt.c+15 -170 replies
37/57sbc60xxwdt: clean up and switch to unlocked_ioctldrivers/watchdog/sbc60xxwdt.c+110 -1130 replies
38/57stg7240_wdt: unlocked_ioctldrivers/watchdog/sbc7240_wdt.c+7 -90 replies
39/57sbc8360: clean updrivers/watchdog/sbc8360.c+12 -180 replies
40/57sbc_epx_c3_wdt: switch to unlocked_ioctldrivers/watchdog/sbc_epx_c3.c+6 -60 replies
41/57sb_wdog: Clean up and switch to unlocked_ioctldrivers/watchdog/sb_wdog.c+40 -380 replies
42/57sc1200_wdt: clean up, fix locking and use unlocked_ioctldrivers/watchdog/sc1200wdt.c+114 -890 replies
43/57sc520_wdt: Clean up and switch to unlocked_ioctldrivers/watchdog/sc520_wdt.c+86 -750 replies
44/57scx200_wdt: clean up and switch to unlocked_ioctldrivers/watchdog/sc520_wdt.c drivers/watchdog/scx200_wdt.c+32 -310 replies
45/57shwdt: coding style, cleanup, switch to unlocked_ioctldrivers/watchdog/shwdt.c+82 -570 replies
46/57smsc37b787_wdt: coding style, switch to unlocked_ioctldrivers/watchdog/smsc37b787_wdt.c+222 -2200 replies
47/57softdog: clean up, coding style and switch to unlocked_ioctldrivers/watchdog/softdog.c+46 -410 replies
48/57txx9: Fix locking, switch to unlocked_ioctldrivers/watchdog/txx9wdt.c+19 -120 replies
49/57w83627hf: coding style, clean up and switch to unlocked_ioctldrivers/watchdog/w83627hf_wdt.c+83 -920 replies
50/57w83697hf_wdt: cleanup, coding style and switch to unlocked_ioctldrivers/watchdog/w83697hf_wdt.c+69 -720 replies
51/57w83877f_wdt: clean up code, coding style, switch to unlocked_ioctldrivers/watchdog/w83877f_wdt.c+101 -980 replies
52/57w83977f_wdt: clean up, coding style and switch to unlocked_ioctldrivers/watchdog/w83977f_wdt.c+111 -1140 replies
53/57wafer5823wdt: Clean up, coding style, switch to unlocked_ioctldrivers/watchdog/wafer5823wdt.c+46 -340 replies
54/57wdrtas: clean up, coding style, switch to unlocked_ioctldrivers/watchdog/wdrtas.c+41 -620 replies
55/57wdt285: switch to unlocked_ioctl and tidy up oddments of coding styledrivers/watchdog/wdt285.c+16 -150 replies
56/57wdt977: clean up, coding style and switch to unlocked_ioctldrivers/watchdog/wdt977.c+74 -740 replies
57/57wdt501/pci: Clean up, coding style and switch to unlocked_ioctldrivers/watchdog/wdt.c drivers/watchdog/wdt_pci.c+265 -2110 replies

Reviews trailers per patch

1 of 57 patches has a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/57
2/57
3/57
4/57
5/57
6/57
7/57
8/57
9/57
10/57
11/57
12/57
13/57
14/57
15/57
16/57
17/57
18/57
19/57
20/57
21/57
22/57
23/57
24/57
25/57
26/57
27/57
28/57A-b
29/57
30/57
31/57
32/57
33/57
34/57
35/57
36/57
37/57
38/57
39/57
40/57
41/57
42/57
43/57
44/57
45/57
46/57
47/57
48/57
49/57
50/57
51/57
52/57
53/57
54/57
55/57
56/57
57/57

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/57] watchdog: Giant scrub

Out damn'd lock, out I say...

The gnomes have been having a spring clean. This tidy up brings all of the watchdog drivers into coding style (except where it doesn't make sense). I've also systematically

- Checked and if need be fixed the locking
- Removed the use of semaphores for open/close handling
- Switched them to unlocked_ioctl
- Checked there are no misc_register races for BKL dropping later

I've also eliminated an escaped use of inb/outb_p on a PCI device

These cover so many architectures I've not been able to build test the lot so there may be the old follow up needed on the build front.

Alan

---

Alan Cox (57):
wdt501/pci: Clean up, coding style and switch to unlocked_ioctl
wdt977: clean up, coding style and switch to unlocked_ioctl
wdt285: switch to unlocked_ioctl and tidy up oddments of coding style
wdrtas: clean up, coding style, switch to unlocked_ioctl
wafer5823wdt: Clean up, coding style, switch to unlocked_ioctl
w83977f_wdt: clean up, coding style and switch to unlocked_ioctl
w83877f_wdt: clean up code, coding style, switch to unlocked_ioctl
w83697hf_wdt: cleanup, coding style and switch to unlocked_ioctl
w83627hf: coding style, clean up and switch to unlocked_ioctl
txx9: Fix locking, switch to unlocked_ioctl
softdog: clean up, coding style and switch to unlocked_ioctl
smsc37b787_wdt: coding style, switch to unlocked_ioctl
shwdt: coding style, cleanup, switch to unlocked_ioctl
scx200_wdt: clean up and switch to unlocked_ioctl
sc520_wdt: Clean up and switch to unlocked_ioctl
sc1200_wdt: clean up, fix locking and use unlocked_ioctl
sb_wdog: Clean up and switch to unlocked_ioctl
sbc_epx_c3_wdt: switch to unlocked_ioctl
sbc8360: clean up
stg7240_wdt: unlocked_ioctl
sbc60xxwdt: clean up and switch to unlocked_ioctl
sa1100_wdt: Switch to unlocked_ioctl
s3c2410: watchdog cleanup and switch to unlocked_ioctl
rm9k_wdt: clean up
pnx4008_wdt: unlocked_ioctl setup
pcwd: clean up, unlocked_ioctl usage
pc87413_wdt: clean up, coding style, unlocked_ioctl
omap_wdt: locking, unlocked_ioctl, tidy
mv64x60_wdt: clean up and locking checks
mtx-1_wdt: clean up, coding style, unlocked ioctl
mpcore watchdog: unlocked_ioctl and BKl work
mpc watchdog: clean up and locking
mixcomwd: coding style locking, unlocked_ioctl
machzwd: clean up, coding style, unlocked_ioctl
ks8695_wdt: clean up, coding style, unlocked_ioctl
ixp4xx_wdt: unlocked_ioctl
ixp2000_wdt: clean up and unlocked_ioctl
booke watchdog: clean up and unlocked_ioctl
bfin: watchdog cleanup and unlocked_ioctl
iTCO: unlocked_ioctl, coding style and cleanup
it8712f: unlocked_ioctl
iop: watchdog switch to unlocked_ioctl
indydog: Clean up and tidy
ibmasr: coding style, locking verify
i6300esb: Style, unlocked_ioctl, cleanup
ib700wdt: clean up and switch to unlocked_ioctl
hpwdt: couple of include cleanups
eurotechwdt: unlocked_ioctl, code lock check and tidy
ep93xx_wdt: unlocked_ioctl
davinci_wdt: unlocked_ioctl and check locking
cpu5_wdt: switch to unlocked_ioctl
at91: watchdog to unlocked_ioctl
atp watchdog
AR7 watchdog
ali: watchdog locking and style
clean up and check advantech watchdog
Clean acquirewdt and check for BKL dependancies

 drivers/char/ip2/Makefile              |    4 
 drivers/char/ip2/ip2main.c             |   23 --
 drivers/watchdog/acquirewdt.c          |  119 ++++-----
 drivers/watchdog/advantechwdt.c        |  133 ++++------
 drivers/watchdog/alim1535_wdt.c        |  186 +++++++------
 drivers/watchdog/alim7101_wdt.c        |  224 +++++++++-------
 drivers/watchdog/ar7_wdt.c             |   29 +-
 drivers/watchdog/at32ap700x_wdt.c      |    7 -
 drivers/watchdog/at91rm9200_wdt.c      |  108 ++++----
 drivers/watchdog/bfin_wdt.c            |  147 +++++------
 drivers/watchdog/booke_wdt.c           |   57 ++--
 drivers/watchdog/cpu5wdt.c             |  144 +++++-----
 drivers/watchdog/davinci_wdt.c         |   11 -
 drivers/watchdog/ep93xx_wdt.c          |   17 +
 drivers/watchdog/eurotechwdt.c         |   57 +++-
 drivers/watchdog/hpwdt.c               |    4 
 drivers/watchdog/i6300esb.c            |  342 ++++++++++++-------------
 drivers/watchdog/iTCO_vendor.h         |   15 +
 drivers/watchdog/iTCO_vendor_support.c |   53 ++--
 drivers/watchdog/iTCO_wdt.c            |  294 ++++++++++-----------
 drivers/watchdog/ib700wdt.c            |  103 ++++---
 drivers/watchdog/ibmasr.c              |  149 ++++++-----
 drivers/watchdog/indydog.c             |  114 ++++----
 drivers/watchdog/iop_wdt.c             |   46 ++-
 drivers/watchdog/it8712f_wdt.c         |   77 ++----
 drivers/watchdog/ixp2000_wdt.c         |   50 ++--
 drivers/watchdog/ixp4xx_wdt.c          |   41 +--
 drivers/watchdog/ks8695_wdt.c          |  119 ++++-----
 drivers/watchdog/machzwd.c             |  108 +++-----
 drivers/watchdog/mixcomwd.c            |  133 +++++-----
 drivers/watchdog/mpc5200_wdt.c         |   20 +
 drivers/watchdog/mpc83xx_wdt.c         |   19 +
 drivers/watchdog/mpc8xx_wdt.c          |   37 +--
 drivers/watchdog/mpcore_wdt.c          |   53 ++--
 drivers/watchdog/mtx-1_wdt.c           |  107 ++++----
 drivers/watchdog/mv64x60_wdt.c         |   20 +
 drivers/watchdog/omap_wdt.c            |   35 ++-
 drivers/watchdog/pc87413_wdt.c         |  211 ++++++---------
 drivers/watchdog/pcwd.c                |  179 +++++++------
 drivers/watchdog/pnx4008_wdt.c         |   18 +
 drivers/watchdog/rm9k_wdt.c            |   21 +-
 drivers/watchdog/s3c2410_wdt.c         |  148 ++++++-----
 drivers/watchdog/sa1100_wdt.c          |   32 +-
 drivers/watchdog/sb_wdog.c             |   78 +++---
 drivers/watchdog/sbc60xxwdt.c          |  223 ++++++++--------
 drivers/watchdog/sbc7240_wdt.c         |   16 +
 drivers/watchdog/sbc8360.c             |   30 +-
 drivers/watchdog/sbc_epx_c3.c          |   12 -
 drivers/watchdog/sc1200wdt.c           |  203 ++++++++-------
 drivers/watchdog/sc520_wdt.c           |  163 ++++++------
 drivers/watchdog/scx200_wdt.c          |   59 ++--
 drivers/watchdog/shwdt.c               |  139 ++++++----
 drivers/watchdog/smsc37b787_wdt.c      |  442 ++++++++++++++++----------------
 drivers/watchdog/softdog.c             |   87 +++---
 drivers/watchdog/txx9wdt.c             |   31 +-
 drivers/watchdog/w83627hf_wdt.c        |  175 ++++++-------
 drivers/watchdog/w83697hf_wdt.c        |  141 +++++-----
 drivers/watchdog/w83877f_wdt.c         |  199 +++++++-------
 drivers/watchdog/w83977f_wdt.c         |  225 ++++++++--------
 drivers/watchdog/wafer5823wdt.c        |   80 +++---
 drivers/watchdog/wdrtas.c              |  103 +++----
 drivers/watchdog/wdt.c                 |  176 +++++++------
 drivers/watchdog/wdt285.c              |   31 +-
 drivers/watchdog/wdt977.c              |  148 +++++------
 drivers/watchdog/wdt_pci.c             |  300 ++++++++++++----------
 65 files changed, 3479 insertions(+), 3396 deletions(-)
 create mode 100644 drivers/watchdog/iTCO_vendor.h
Signature · 4 lines
       "Also I poked a hole in the projector screen when pointing my
        replica Roman sword at the site of the Battle of Lake Regillus
        and am in Big Trouble."
                        -- Matthew Peacock

Read the cover letter in its thread