Skip to content

Initial set of 2.6.27 patches, take 3

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am 20080521180231.3295.84997.stgit@ellison

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6NFS: Update help text for CONFIG_NFS_FSfs/Kconfig+57 -580 replies
2/6SUNRPC: Add a function to display the name of an RPC procedurenet/sunrpc/clnt.c+19 -40 replies
3/6SUNRPC: Rename "call_" functions that are no longer FSM statesnet/sunrpc/clnt.c+14 -210 replies
4/6SUNRPC: Don't display the rpc_show_tasks header if there are no tasksnet/sunrpc/clnt.c+12 -70 replies
5/6SUNRPC: Refactor rpc_show_tasksnet/sunrpc/clnt.c+24 -220 replies
6/6SUNRPC: Display some debugging information as text rather than numbersnet/sunrpc/clnt.c+16 -135 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Initial set of 2.6.27 patches, take 3

Hi Trond-

Resending the first batch of 2.6.27 patches, with additional fixes.

Using the RPC procedure name in debugging messages should no longer add a risk of a segmentation fault.

I've also done a third re-implementation of the tk_action function name patch. I finally managed to find an interface that will perform the symbol table lookup, and can be called from a module or from built-in code.

Oddly this API has been around for a while; I'm not sure how I missed it originally. But it should implement the nice function-name-rather-than- memory-address feature without a wonky table, and without requiring any additional changes when adding a new FSM state function. It will display the function name if the lookup succeeds; otherwise it will display a hex memory address. It works for any arbitrary pointer stored in the tk_action field.

I've thought of a couple of other ways rpc_show_tasks() could be improved. First, it could display the IP address of the server handling each request; and it should have a different column layout for systems with 64-bit addresses. All for another day, I suppose.

---

Chuck Lever (6):
SUNRPC: Display some debugging information as text rather than numbers
SUNRPC: Refactor rpc_show_tasks
SUNRPC: Don't display the rpc_show_tasks header if there are no tasks
SUNRPC: Rename "call_" functions that are no longer FSM states
SUNRPC: Add a function to display the name of an RPC procedure
NFS: Update help text for CONFIG_NFS_FS

 fs/Kconfig        |  115 ++++++++++++++++++++++++-------------------------
 net/sunrpc/clnt.c |  124 ++++++++++++++++++++++++++++++-----------------------
 2 files changed, 128 insertions(+), 111 deletions(-)
Signature · 1 line
Signature