Skip to content

ide: convert ide-timing.h to ide-timings.c library

Bartlomiej Zolnierkiewicz linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21ide: remove needless includes from ide-lib.cdrivers/ide/ide-lib.c+0 -150 replies
2/21ide: remove unused XFER_UDMA_SLOWdrivers/ide/ide-timing.h+1 -61 reply
3/21ide: use u8 for xfer modes in ide-timing.hdrivers/ide/ide-timing.h+6 -51 reply
4/21ide: move some bits from ide-timing.h to <linux/ide.h>drivers/ide/ide-timing.h include/linux/ide.h+28 -231 reply
5/21ide: remove XFER_* masks from ide-timing.hdrivers/ide/ide-timing.h drivers/ide/pci/cs5535.c+8 -201 reply
6/21ide: checkpatch.pl fixes for ide-timing.hdrivers/ide/ide-timing.h+48 -451 reply
7/21ide: convert ide-timing.h to ide-timings.c librarydrivers/ide/Kconfig drivers/ide/Makefile drivers/ide/arm/palm_bk3710.c +8 more+192 -1960 replies
8/21ali14xx: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/legacy/ali14xx.c+3 -11 reply
9/21ht6560b: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/legacy/ht6560b.c+4 -41 reply
10/21qd65xx: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/legacy/qd65xx.c+3 -11 reply
11/21alim15x3: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/alim15x3.c+3 -41 reply
12/21cmd640: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/cmd640.c+7 -22 replies
13/21cmd64x: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/cmd64x.c+4 -31 reply
14/21cy82c693: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/cy82c693.c+5 -51 reply
15/21opti621: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/opti621.c+6 -51 reply
16/21sl82c105: convert to use ide_timing_find_mode()drivers/ide/Kconfig drivers/ide/pci/sl82c105.c+3 -11 reply
17/21ide-mpc8xx: convert to use ide_timing_find_mode()drivers/ide/ppc/mpc8xx.c+13 -200 replies
18/21ide-pmac: convert to use ide_timing_find_mode()drivers/ide/ppc/pmac.c+6 -71 reply
19/21ide: move ide_pio_cycle_time() to ide-timings.cdrivers/ide/ide-lib.c drivers/ide/ide-timings.c include/linux/ide.h+23 -241 reply
20/21ide: remove no longer used ide_pio_timings[]drivers/ide/ide-lib.c include/linux/ide.h+0 -251 reply
21/21ide: move PIO blacklist to ide-pio-blacklist.cdrivers/ide/Makefile drivers/ide/ide-lib.c drivers/ide/ide-pio-blacklist.c +1 more+98 -970 replies

Reviews trailers per patch

17 of 21 patches have a Reviewed-by or Acked-by.

PatchSergei Shtylyov
1/21
2/21A-b
3/21A-b
4/21A-b
5/21A-b
6/21A-b
7/21
8/21A-b
9/21A-b
10/21A-b
11/21A-b
12/21A-b A-b
13/21A-b
14/21A-b
15/21A-b
16/21A-b
17/21
18/21A-b
19/21A-b
20/21A-b
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/21] ide: convert ide-timing.h to ide-timings.c library

This (fairly obvious/trivial) patchset converts drivers/ide/ide-timing.h into ide-timings.c library (enabled by host drivers that want to use it by selecting CONFIG_IDE_TIMINGS config option) and updates host drivers still using ide_pio_timings[] to use ide_timing_find_mode() instead.

Also as a bonus it moves PIO blacklist from ide-lib.c to ide-pio-blacklist.c.

diffstat:

 drivers/ide/Kconfig             |   16 +
 drivers/ide/Makefile            |    4 
 drivers/ide/arm/palm_bk3710.c   |    2 
 drivers/ide/ide-lib.c           |  151 -----------------
 drivers/ide/ide-pio-blacklist.c |   94 +++++++++++
 drivers/ide/ide-timing.h        |  341 +++++++---------------------------------
 drivers/ide/ide-timings.c       |  201 +++++++++++++++++++++++
 drivers/ide/legacy/ali14xx.c    |    3 
 drivers/ide/legacy/ht6560b.c    |    7 
 drivers/ide/legacy/qd65xx.c     |    3 
 drivers/ide/pci/alim15x3.c      |    6 
 drivers/ide/pci/amd74xx.c       |    2 
 drivers/ide/pci/cmd640.c        |    8 
 drivers/ide/pci/cmd64x.c        |    6 
 drivers/ide/pci/cs5535.c        |    6 
 drivers/ide/pci/cy82c693.c      |    9 -
 drivers/ide/pci/opti621.c       |   10 -
 drivers/ide/pci/sis5513.c       |    3 
 drivers/ide/pci/sl82c105.c      |    3 
 drivers/ide/pci/via82cxxx.c     |    2 
 drivers/ide/ppc/mpc8xx.c        |   33 +--
 drivers/ide/ppc/pmac.c          |   15 -
 include/linux/ide.h             |   45 ++++-
 23 files changed, 461 insertions(+), 509 deletions(-)