Skip to content

RFC Submodule support in git mv, git rm

Petr Baudis git lkml 1 version In review

Get series with b4
b4 am 20080716190753.19772.93357.stgit@localhost

Versions newest first

  1. v1 RFC Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7git-mv: Remove dead code branchbuiltin-mv.c+7 -90 replies
2/7t7400: Add short "git submodule add" testsuitet/t7400-submodule-basic.sh+27 -10 replies
3/7git submodule add: Fix naming clash handlinggit-submodule.sh t/t7400-submodule-basic.sh+23 -30 replies
4/7submodule.*: Introduce simple C interface for submodule lookup by pathMakefile submodule.c submodule.h+60 -00 replies
5/7git mv: Support moving submodulesbuiltin-mv.c cache.h sha1_file.c+61 -647 replies
6/7git rm: Support for removing submodulesDocumentation/git-rm.txt builtin-rm.c+58 -133 replies
7/7t7403: Submodule git mv, git rm testsuitet/t7403-submodule-mvrm.sh+242 -00 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchStephen Rothwell
1/7
2/7
3/7
4/7
5/7A-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC][PATCH 0/7] Submodule support in git mv, git rm

The following series implements submodule support in git mv and git rm, plus enhancing the submodules testsuite a bit. I'd appreciate comments, especially on the git mv change, since the index_path_src_sha1 is really a horrible hack.

The pinnacle of this series was supposed to be merge-recursive support for submodule-somethingelese conflicts, however that seems a bit more complicated than I expected, so I decided to first send the rest for a review.

---

Petr Baudis (7):
t7403: Submodule git mv, git rm testsuite
git rm: Support for removing submodules
git mv: Support moving submodules
submodule.*: Introduce simple C interface for submodule lookup by path git submodule add: Fix naming clash handling
t7400: Add short "git submodule add" testsuite
git-mv: Remove dead code branch

 Documentation/git-rm.txt   |    6 +
 Makefile                   |    2 
 builtin-mv.c               |   67 ++++++++++--
 builtin-rm.c               |   65 ++++++++++--
 cache.h                    |    2 
 git-submodule.sh           |   15 ++-
 sha1_file.c                |   10 ++
 submodule.c                |   50 +++++++++
 submodule.h                |    8 +
 t/t7400-submodule-basic.sh |   39 +++++++
 t/t7403-submodule-mvrm.sh  |  242 ++++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 476 insertions(+), 30 deletions(-)
 create mode 100644 submodule.c
 create mode 100644 submodule.h
 create mode 100755 t/t7403-submodule-mvrm.sh