Skip to content

RFC mac80211 tx mq aggregation fixes

Johannes Berg linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mac80211: sane arguments to ieee80211_ht_agg_queue_removenet/mac80211/main.c net/mac80211/wme.c net/mac80211/wme.h+7 -110 replies
2/3mac80211: fix race during adding HT queuesnet/mac80211/ieee80211_i.h net/mac80211/main.c net/mac80211/wme.c+26 -140 replies
3/3mac80211: fix requeue racedrivers/net/wireless/iwlwifi/iwl-tx.c include/net/mac80211.h net/mac80211/ieee80211_i.h +3 more+175 -781 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] mac80211 tx mq aggregation fixes

As we discussed earlier, there is now a race in mac80211 where you can get packets queued onto the aggregation queue while draining it, and some can be left on there. Fixing that is achieved by deferring the draining to a workqueue and calling synchronize_net() before doing it.

Also noticed another problem: when we start aggregation we add the queue before the hardware said it's ok, thus we can end up queuing packets to a new aggregation queue we won't be using, fix that one before since it was easier.

Locking gets a bit tricky unfortunately.

johannes