ide: /proc/ide/hd*/settings rework
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ide: call ide_proc_register_driver() laterdrivers/ drivers/ drivers/ +2 more | +8 | 0 replies | |
| 2/3 | ide: preparations for /proc/ide/hd*/settings reworkdrivers/ drivers/ drivers/ +1 more | +8 | 0 replies | |
| 3/3 | ide: /proc/ide/hd*/settings reworkdrivers/ drivers/ drivers/ +6 more | +340 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] ide: /proc/ide/hd*/settings rework
Hi,
I finally dusted off /proc/ide/hd*/settings rework (this has been laying on my hdd and waiting for the better days for at least 1.5 year, draft version even longer like ~3 years... sigh).
The main motivation for doing it is that with infrastructure for private IDE subsystem requests from Elias Oltmanns (which was merged recently) and this patchset it should be possible (by using private requests for device settings) to make IDE locking code a lot saner and get rid of of ide_spin_wait_hwgroup()-ugliness completely.
Elias if you would like to take care of it please go ahead [ from a quick look it seems this would mostly require adding new request type, pointing rq->special to setting's ->get or ->set method and putting setting's type (read/write -> 1 bit) + argument (int) somewhere inside request but you probably know better ].
Patches #1-2 are a preparatory cleanups, the main rework is in patch #3.
diffstat:
drivers/ide/ide-cd.c | 20 +-- drivers/ide/ide-disk.c | 94 ++++++++------- drivers/ide/ide-floppy.c | 39 ++++-- drivers/ide/ide-probe.c | 2 drivers/ide/ide-proc.c | 285 ++++++++++++++--------------------------------- drivers/ide/ide-tape.c | 77 ++++++++---- drivers/ide/ide.c | 25 ++-- drivers/scsi/ide-scsi.c | 54 ++++++-- include/linux/ide.h | 112 ++++++++++++------ 9 files changed, 356 insertions(+), 352 deletions(-)