Skip to content

ide: more work on generic ATAPI support

Bartlomiej Zolnierkiewicz linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22ide-floppy: fixup ide_floppy_io_buffers()drivers/ide/ide-floppy.c+9 -60 replies
2/22ide-scsi: cleanup ide_scsi_io_buffers()drivers/scsi/ide-scsi.c+8 -80 replies
3/22ide: add ide_io_buffers() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +2 more+67 -970 replies
4/22ide-floppy: add ide_floppy_set_media_lock() helperdrivers/ide/ide-floppy.c+16 -231 reply
5/22ide-tape: add ide_tape_set_media_lock() helperdrivers/ide/ide-tape.c+19 -200 replies
6/22ide: add ide_init_pc() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+39 -540 replies
7/22ide: add ide_queue_pc_head() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+38 -551 reply
8/22ide: add ide_queue_pc_tail() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+69 -731 reply
9/22ide-floppy: ->{srfp,wp} -> IDE_AFLAG_{SRFP,WP}drivers/ide/ide-floppy.c include/linux/ide.h+24 -160 replies
10/22ide-floppy: move floppy ioctls handling to ide-floppy_ioctl.cdrivers/ide/Makefile drivers/ide/ide-floppy.c drivers/ide/ide-floppy.h +1 more+317 -2880 replies
11/22ide: add ide_set_media_lock() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+36 -584 replies
12/22ide: add ide_do_start_stop() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+24 -350 replies
13/22ide: add ide_do_test_unit_ready() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +1 more+14 -141 reply
14/22ide: move IDE{FLOPPY,TAPE}_WAIT_CMD defines to <linux/ide.h>drivers/ide/ide-floppy.c drivers/ide/ide-tape.c include/linux/ide.h+29 -250 replies
15/22ide: drop dsc_handle argument from ide_pc_intr()drivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +2 more+23 -210 replies
16/22ide: add pointer to the current packet command to ide_drive_tdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy.h +3 more+60 -700 replies
17/22ide: drop 'timeout' and 'expiry' arguments from ide_pc_intr()drivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +2 more+42 -350 replies
18/22ide: add request_sense_{pc,rq} to ide_drive_tdrivers/ide/ide-floppy.c drivers/ide/ide-floppy.h drivers/ide/ide-tape.c +1 more+72 -760 replies
19/22ide: add ide_retry_pc() helperdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy.h +4 more+41 -620 replies
20/22ide: add ->pc_{update,io}_buffers methodsdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +2 more+23 -200 replies
21/22ide: make ide_pc_intr() staticdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-tape.c +2 more+16 -420 replies
22/22ide: make ide_transfer_pc() staticdrivers/ide/ide-atapi.c drivers/ide/ide-floppy.c drivers/ide/ide-floppy.h +3 more+49 -890 replies

Reviews trailers per patch

4 of 22 patches have a Reviewed-by or Acked-by.

PatchSergei Shtylyov
1/22
2/22
3/22
4/22A-b
5/22
6/22
7/22A-b
8/22A-b
9/22
10/22
11/22
12/22
13/22A-b
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/22] ide: more work on generic ATAPI support

Just some more work on generic ATAPI layer...

- code unifications here and there

- move IDEFLOPPY_IOCTL_FORMAT_* support to a separate file

- ide_pc_intr() no longer requires zillion of arguments

Applies on top of current pata tree, tested with ide-scsi.

diffstat:

 drivers/ide/Makefile           |    3 
 drivers/ide/ide-atapi.c        |  323 +++++++++++++++--
 drivers/ide/ide-floppy.c       |  739 ++++++-----------------------------------
 drivers/ide/ide-floppy.h       |   72 +++
 drivers/ide/ide-floppy_ioctl.c |  245 +++++++++++++
 drivers/ide/ide-tape.c         |  396 ++++++---------------
 drivers/scsi/ide-scsi.c        |  178 ++-------
 include/linux/ide.h            |  266 +++++++++-----
 8 files changed, 1035 insertions(+), 1187 deletions(-)