Skip to content

sfc: Changes for 2.6.28

Ben Hutchings netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest52 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/52sfc: Replace net_dev->priv with netdev_priv(net_dev)drivers/net/sfc/efx.c drivers/net/sfc/ethtool.c drivers/net/sfc/falcon.c +1 more+32 -320 replies
2/52sfc: Change first parameter type of {set,clear}_bit_le() to unsigneddrivers/net/sfc/net_driver.h+2 -20 replies
3/52sfc: Remove unused field efx_channel::reset_workdrivers/net/sfc/net_driver.h+0 -10 replies
4/52sfc: Use separate hardware TX queues to select checksum generationdrivers/net/sfc/efx.c drivers/net/sfc/ethtool.c drivers/net/sfc/falcon.c +4 more+48 -920 replies
5/52sfc: Avoid mangling error codes in efx_test_loopback()drivers/net/sfc/selftest.c+6 -60 replies
6/52sfc: Reduce delays in SFE4001 initialisationdrivers/net/sfc/sfe4001.c+35 -220 replies
7/52sfc: Remove mistaken hardware workarounddrivers/net/sfc/falcon.c drivers/net/sfc/workarounds.h+4 -630 replies
8/52sfc: XMAC statistics fix-upsdrivers/net/sfc/falcon_xmac.c+4 -20 replies
9/52sfc: Remove inclusion of workarounds.h from efx.cdrivers/net/sfc/efx.c+0 -10 replies
10/52sfc: Reverse the XOFF/XON pause frame control fifo thresholdsdrivers/net/sfc/falcon.c+2 -20 replies
11/52sfc: Reduce log level for XGXS lane statusdrivers/net/sfc/mdio_10g.h+1 -10 replies
12/52sfc: Self-test reporting cleanupdrivers/net/sfc/selftest.c+16 -260 replies
13/52sfc: Speed up loopback self-testdrivers/net/sfc/selftest.c+29 -150 replies
14/52sfc: Don't leak PCI DMA maps in the TSO code when the queue fills updrivers/net/sfc/tx.c+5 -00 replies
15/52sfc: Use pci_map_single() to map the skb header when doing TSOdrivers/net/sfc/tx.c+83 -690 replies
16/52sfc: Reduce the size of struct efx_tx_bufferdrivers/net/sfc/net_driver.h drivers/net/sfc/tx.c+11 -110 replies
17/52sfc: Use explicit bool for boolean variables, parameters and return valuesdrivers/net/sfc/boards.c drivers/net/sfc/efx.c drivers/net/sfc/efx.h +15 more+175 -1780 replies
18/52sfc: Set net_device::vlan_features appropriatelydrivers/net/sfc/efx.c+3 -00 replies
19/52sfc: Cleaned up struct tso_state fieldsdrivers/net/sfc/tx.c+75 -860 replies
20/52sfc: Removed forced inlining of long functionsdrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/rx.c +1 more+49 -500 replies
21/52sfc: Export boot configuration in EEPROM through ethtooldrivers/net/sfc/ethtool.c drivers/net/sfc/falcon.c drivers/net/sfc/falcon_hwdefs.h +2 more+446 -950 replies
22/52sfc: Move CPU counting for RSS into a separate function, efx_wanted_rx_queues()drivers/net/sfc/efx.c+35 -250 replies
23/52sfc: Remove efx_channel::has_interruptdrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h +1 more+12 -670 replies
24/52sfc: Cleanup RX queue informationdrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h +1 more+27 -580 replies
25/52sfc: Remove initialisation of RX_FILTER_CTL_REG.NUM_KERdrivers/net/sfc/falcon.c+2 -70 replies
26/52sfc: Make efx_for_each_channel_rx_queue() more efficientdrivers/net/sfc/net_driver.h+3 -30 replies
27/52sfc: Remove efx_channel::evqnum fielddrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/net_driver.h+7 -100 replies
28/52sfc: Cleanup RX event processingdrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/falcon.h+23 -360 replies
29/52sfc: Implement get_sset_count, replacing get_stats_count and self_test_countdrivers/net/sfc/ethtool.c+12 -110 replies
30/52sfc: Make PHY flash mode a device attribute, not a module parameterdrivers/net/sfc/boards.h drivers/net/sfc/efx.c drivers/net/sfc/falcon_xmac.c +6 more+171 -1230 replies
31/52sfc: Do not call netif_{stop,wake}_queue() before register_netdevdrivers/net/sfc/efx.c+3 -20 replies
32/52sfc: Enable TSO for 802.1q VLAN devicesdrivers/net/sfc/efx.c drivers/net/sfc/tx.c+20 -70 replies
33/52sfc: Remove efx_nic_dummy_op_int() as redundant with efx_port_dummy_op_int()drivers/net/sfc/efx.c+6 -110 replies
34/52sfc: Remove remnants of multi-port abstraction for MAC registersdrivers/net/sfc/falcon_hwdefs.h drivers/net/sfc/falcon_xmac.c drivers/net/sfc/mac.h +1 more+129 -1700 replies
35/52sfc: Remove some unreachable error pathsdrivers/net/sfc/efx.c drivers/net/sfc/efx.h drivers/net/sfc/ethtool.c +6 more+39 -950 replies
36/52sfc: Cleanup reset codedrivers/net/sfc/efx.c+41 -570 replies
37/52sfc: Rework the bitfield header so that we can identify fields by bit numberdrivers/net/sfc/bitfield.h drivers/net/sfc/falcon_hwdefs.h+95 -680 replies
38/52sfc: Extend self-testsdrivers/net/sfc/bitfield.h drivers/net/sfc/efx.c drivers/net/sfc/efx.h +9 more+429 -1840 replies
39/52sfc: Remove the STATE_RESETTING flagdrivers/net/sfc/efx.c drivers/net/sfc/net_driver.h+2 -60 replies
40/52sfc: Rework efx_set_multicast_hash()drivers/net/sfc/efx.c+17 -111 reply
41/52sfc: Add check for memory allocation failure in falcon_probe_nic()drivers/net/sfc/falcon.c+2 -01 reply
42/52sfc: Fix memory BAR release call on error pathdrivers/net/sfc/efx.c+1 -10 replies
43/52sfc: Remove workaround for old firmware bugdrivers/net/sfc/efx.c drivers/net/sfc/falcon_xmac.c drivers/net/sfc/net_driver.h +4 more+1 -1560 replies
44/52sfc: Serialise tenxpress_special_reset() with statistics fetchesdrivers/net/sfc/tenxpress.c+10 -50 replies
45/52sfc: Don't use EFX_OWORD_FIELD on an event (64-bit, quad-word)drivers/net/sfc/falcon.c+1 -10 replies
46/52sfc: Make queue flushes more reliabledrivers/net/sfc/efx.c drivers/net/sfc/falcon.c drivers/net/sfc/falcon.h +1 more+141 -1260 replies
47/52sfc: Don't include net_driver.h from falcon_io.hdrivers/net/sfc/falcon_io.h+0 -10 replies
48/52sfc: Stop generating bogus events in tenxpress_check_hw()drivers/net/sfc/tenxpress.c+1 -20 replies
49/52sfc: Insert read memory barrier after checking MAC statistics flagdrivers/net/sfc/falcon.c+3 -10 replies
50/52sfc: Disable interrupts after a fatal interrupt occurs until resetdrivers/net/sfc/falcon.c+2 -10 replies
51/52sfc: Remove obsolete comment about PCI modesdrivers/net/sfc/falcon_hwdefs.h+0 -10 replies
52/52sfc: Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS where appropriatedrivers/net/sfc/net_driver.h drivers/net/sfc/tx.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/52] sfc: Changes for 2.6.28

Jeff,

Here's a first patch series for sfc in 2.6.28 covering minor fixes and improvements and the addition of EEPROM access and more self-tests through ethtool. We have some more changes in the pipeline for new hardware support which I will submit later.

Ben.

Ben Hutchings (41):
sfc: Replace net_dev->priv with netdev_priv(net_dev)
sfc: Change first parameter type of {set,clear}_bit_le() to unsigned
sfc: Use separate hardware TX queues to select checksum generation
sfc: Avoid mangling error codes in efx_test_loopback()
sfc: Reduce delays in SFE4001 initialisation
sfc: Remove mistaken hardware workaround
sfc: XMAC statistics fix-ups
sfc: Remove inclusion of workarounds.h from efx.c
sfc: Reduce log level for XGXS lane status
sfc: Self-test reporting cleanup
sfc: Speed up loopback self-test
sfc: Don't leak PCI DMA maps in the TSO code when the queue fills up
sfc: Use pci_map_single() to map the skb header when doing TSO
sfc: Reduce the size of struct efx_tx_buffer
sfc: Use explicit bool for boolean variables, parameters and return
values
sfc: Set net_device::vlan_features appropriately
sfc: Cleaned up struct tso_state fields
sfc: Removed forced inlining of long functions
sfc: Export boot configuration in EEPROM through ethtool
sfc: Move CPU counting for RSS into a separate function,
efx_wanted_rx_queues()
sfc: Remove efx_channel::has_interrupt
sfc: Cleanup RX queue information
sfc: Remove initialisation of RX_FILTER_CTL_REG.NUM_KER
sfc: Make efx_for_each_channel_rx_queue() more efficient
sfc: Remove efx_channel::evqnum field
sfc: Cleanup RX event processing
sfc: Implement get_sset_count, replacing get_stats_count and
self_test_count
sfc: Make PHY flash mode a device attribute, not a module parameter
sfc: Enable TSO for 802.1q VLAN devices
sfc: Remove efx_nic_dummy_op_int() as redundant with

    efx_port_dummy_op_int()

sfc: Remove remnants of multi-port abstraction for MAC registers
sfc: Remove some unreachable error paths
sfc: Cleanup reset code
sfc: Extend self-tests
sfc: Remove the STATE_RESETTING flag
sfc: Add check for memory allocation failure in falcon_probe_nic()
sfc: Remove workaround for old firmware bug
sfc: Make queue flushes more reliable
sfc: Disable interrupts after a fatal interrupt occurs until reset
sfc: Remove obsolete comment about PCI modes
sfc: Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS where appropriate

Neil Turton (1):
sfc: Insert read memory barrier after checking MAC statistics flag

Steve Hodgson (10):
sfc: Remove unused field efx_channel::reset_work
sfc: Reverse the XOFF/XON pause frame control fifo thresholds
sfc: Do not call netif_{stop,wake}_queue() before register_netdev
sfc: Rework the bitfield header so that we can identify fields by bit
number
sfc: Rework efx_set_multicast_hash()
sfc: Fix memory BAR release call on error path
sfc: Serialise tenxpress_special_reset() with statistics fetches
sfc: Don't use EFX_OWORD_FIELD on an event (64-bit, quad-word)
sfc: Don't include net_driver.h from falcon_io.h
sfc: Stop generating bogus events in tenxpress_check_hw()

 drivers/net/sfc/bitfield.h      |  178 +++++---
 drivers/net/sfc/boards.c        |   12 +-
 drivers/net/sfc/boards.h        |    2 -
 drivers/net/sfc/efx.c           |  489 ++++++++-----------
 drivers/net/sfc/efx.h           |   14 +-
 drivers/net/sfc/enum.h          |    9 +-
 drivers/net/sfc/ethtool.c       |  184 ++++----
 drivers/net/sfc/falcon.c        | 1017 ++++++++++++++++++++++++++-------------
 drivers/net/sfc/falcon.h        |   17 +-
 drivers/net/sfc/falcon_hwdefs.h |   80 ++-
 drivers/net/sfc/falcon_io.h     |    1 -
 drivers/net/sfc/falcon_xmac.c   |  346 +++++---------
 drivers/net/sfc/mac.h           |    4 -
 drivers/net/sfc/mdio_10g.c      |   16 +-
 drivers/net/sfc/mdio_10g.h      |   13 +-
 drivers/net/sfc/net_driver.h    |  144 +++---
 drivers/net/sfc/phy.h           |   10 +-
 drivers/net/sfc/rx.c            |   78 ++--
 drivers/net/sfc/rx.h            |    4 +-
 drivers/net/sfc/selftest.c      |  391 ++++++++-------
 drivers/net/sfc/selftest.h      |   13 +-
 drivers/net/sfc/sfe4001.c       |  248 ++++++----
 drivers/net/sfc/spi.h           |   89 ++--
 drivers/net/sfc/tenxpress.c     |  149 ++-----
 drivers/net/sfc/tx.c            |  385 ++++++++-------
 drivers/net/sfc/tx.h            |    2 +-
 drivers/net/sfc/workarounds.h   |    4 -
 drivers/net/sfc/xfp_phy.c       |   12 +-
 28 files changed, 2086 insertions(+), 1825 deletions(-)
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.