Skip to content

RFC dynamically allocate arch specific system vectors

Dean Nelson lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4switch vector_irq[] from irq number to irq_desc pointerarch/x86/kernel/io_apic.c arch/x86/kernel/irq_32.c arch/x86/kernel/irq_64.c +5 more+50 -710 replies
2/4introduce dynamically allocated system vectorsarch/x86/kernel/apic.c arch/x86/kernel/io_apic.c arch/x86/kernel/irqinit_64.c +3 more+258 -402 replies
3/4switch static system vector allocation to use vector_irq[]arch/x86/kernel/apic.c arch/x86/kernel/io_apic.c arch/x86/kernel/irq_32.c +4 more+34 -220 replies
4/4switch non-standard SYSCALL_VECTOR allocation to use vector_irq[]arch/x86/kernel/traps_32.c drivers/lguest/interrupts_and_traps.c include/asm-x86/irq.h+33 -152 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/4] dynamically allocate arch specific system vectors
Quoted 3 lines · Eric W. Biederman

Although I am not at all convinced that dynamic allocation of the vector number (instead of statically reserving it makes sense).

We (SGI) need somewhere around eight vectors.

There are two kernel modules, sgi-gru and sgi-xp (in drivers/misc), that each need two vectors. And there's the broadcast assist unit (BAU) that is involved in tlb shootdown on uv, which currently uses statically reserved vector 0xf8 (UV_BAU_MESSAGE -- see uv_bau_init()). I know of a debugger that also uses 0xf8 because it was previously available until UV_BAU_MESSAGE came along. The BAU would be happy with a dynamically allocated system vector. We have a couple of other things in the works that also need vectors.

All of these eight or so vectors are only meaningful on SGI uv systems.

We'll go with which ever way you decide on this (dynamically allocated or statically reserved).

But we really need to get something into 2.6.28. So in order to move forward I'm submitting the following patchset for comment. This set of four patches represents my take on Eric's suggested approach to supporting dynamically allocated system vectors (i.e., __grab_irq_vector()).

Eric, is this what you were thinking of? Or did I miss the mark?

Thanks,
Dean