Skip to content

RFC timers: add_timer should never be called if pending

Krishna Kumar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1: timers: Change add_timer to use add_timer_oninclude/linux/timer.h+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC] [PATCH 0/1] timers: add_timer should never be called if pending

From: Krishna Kumar <[email protected]>

(Hopefully this is not something that has been suggested earlier and rejected).

add_timer should never be called on a pending timer - such bugs should be caught by reports generated by debug kernels. It is the responsibility of the subsystem users to ensure that timers are not added twice. Using the add_timer_on interface reduces the code that checks if the timer is pending, the timer_base change, updating 'expires' two times, etc.

1. Single CPU, Single Timer: Add the same timer serially on one CPU - do this many times.

	Laptop (2 way Xeon): Saves 10.8%
		ORG: Time: 35359
		NEW: Time: 31527
	Server (4 way x86-64): Saves 7.9%
		ORG: Time: 4520
		NEW: Time: 4164
2. Single CPU, Multiple Timer: Add different timers serially on one CPU - do
   this many times.
	Laptop (2 way Xeon): Saves 7.7%
		ORG: Time: 133728
		NEW: Time: 144822
	Server (4 way x86-64): Saves 15.7%
		ORG: Time: 69012
		NEW: Time: 58186
3. Many CPU's, Single Timer: Add the same timer in parallel on all CPUs - do
   this many times.
	Laptop (2 way Xeon): Saves 14%
		ORG: Time: 69845
		NEW: Time: 60067
	Server (4 way x86-64): Saves 21.8%
		ORG: Time: 18047
		NEW: Time: 14116
4. Many CPU's, Multiple Timer: Add different timers in parallel on all CPUs -
   do this many times.
	Laptop (2 way Xeon): Saves 47.1%
		ORG: Time: 292173
		NEW: Time: 154485
	Server (4 way x86-64): Saves 8.23
		ORG: Time: 319129
		NEW: Time: 292842