Skip to content

btree cleanups V2

Christoph Hellwig linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6fix up btree headers for userspacefs/xfs/xfs_bmap_btree.h fs/xfs/xfs_btree.h+0 -70 replies
2/6make xfsidbg independent of the main btree implementationfs/xfs/xfsidbg.c+189 -1500 replies
3/6cleanup maxrecs calculationfs/xfs/xfs_alloc_btree.c fs/xfs/xfs_alloc_btree.h fs/xfs/xfs_bmap.c +10 more+158 -1220 replies
4/6cleanup btree record / key / ptr addressing macrosfs/xfs/xfs_alloc_btree.c fs/xfs/xfs_alloc_btree.h fs/xfs/xfs_bmap.c +6 more+113 -970 replies
5/6always use struct xfs_btree_block instead of short / longform structuresfs/xfs/xfs_alloc.c fs/xfs/xfs_alloc_btree.c fs/xfs/xfs_alloc_btree.h +13 more+168 -1911 reply
6/6move XFS_BMAP_SANITY_CHECK out of linefs/xfs/xfs_bmap.c fs/xfs/xfs_bmap_btree.h+19 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] btree cleanups V2

Here's a set of a few small btree cleanup patches. Most of them are in preparation of adding CRC support to the btree blocks. All these require the generic btree patchset to be applied first.

Compared to version 1 I've addressed Dave's review comments. I decided to keep XFS_BMAP_BROOT_PTR_ADDR because it's used a few times and already in long enough lines that would start to get unreadable if we expanded it. I've also left the odd boolean arguments to the maxrecs functions as is for now, but I have some plans to tackle that from a higher level view later.