Skip to content

freeze feature ver 1.13

Takashi Sato dm-devel linux-ext4 linux-fsdevel linux-xfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10VFS: Fix error handling of write_super_lockfs/unlockfsDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/buffer.c +1 more+14 -140 replies
1/10VFS: Fix error handling of write_super_lockfs/unlockfsDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/buffer.c +1 more+14 -140 replies
2/10ext3: Fix error handling in write_super_lockfs/unlockfsfs/ext3/super.c+29 -150 replies
2/10ext3: Fix error handling in write_super_lockfs/unlockfsfs/ext3/super.c+29 -150 replies
2/10ext3: Fix error handling in write_super_lockfs/unlockfsfs/ext3/super.c+29 -150 replies
3/10ext4: Fix error handling in write_super_lockfs/unlockfsfs/ext4/super.c+27 -130 replies
3/10ext4: Fix error handling in write_super_lockfs/unlockfsfs/ext4/super.c+27 -130 replies
4/10xfs: Fix error handling in write_super_lockfs/unlockfsfs/xfs/linux-2.6/xfs_super.c fs/xfs/xfs_fsops.c fs/xfs/xfs_fsops.h+12 -90 replies
4/10xfs: Fix error handling in write_super_lockfs/unlockfsfs/xfs/linux-2.6/xfs_super.c fs/xfs/xfs_fsops.c fs/xfs/xfs_fsops.h+12 -90 replies
5/10gfs2: Fix error handling in write_super_lockfs/unlockfsfs/gfs2/ops_super.c+9 -71 reply
5/10gfs2: Fix error handling in write_super_lockfs/unlockfsfs/gfs2/ops_super.c+9 -70 replies
6/10jfs: Fix error handling in write_super_lockfs/unlockfsfs/jfs/super.c+6 -40 replies
6/10jfs: Fix error handling in write_super_lockfs/unlockfsfs/jfs/super.c+6 -40 replies
7/10reiserfs: Fix error handling in write_super_lockfs/unlockfsfs/reiserfs/super.c+6 -40 replies
7/10reiserfs: Fix error handling in write_super_lockfs/unlockfsfs/reiserfs/super.c+6 -40 replies
8/10Implement generic freeze featurefs/block_dev.c fs/buffer.c fs/ioctl.c +2 more+122 -100 replies
8/10Implement generic freeze featurefs/block_dev.c fs/buffer.c fs/ioctl.c +2 more+122 -100 replies
9/10Remove XFS specific ioctl interfaces for freeze featurefs/xfs/linux-2.6/xfs_ioctl.c fs/xfs/linux-2.6/xfs_ioctl32.c fs/xfs/xfs_fs.h+2 -190 replies
9/10Remove XFS specific ioctl interfaces for freeze featurefs/xfs/linux-2.6/xfs_ioctl.c fs/xfs/linux-2.6/xfs_ioctl32.c fs/xfs/xfs_fs.h+2 -190 replies
10/10Add timeout featuredrivers/md/dm.c fs/block_dev.c fs/buffer.c +5 more+159 -110 replies
10/10Add timeout featuredrivers/md/dm.c fs/block_dev.c fs/buffer.c +5 more+159 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/10] freeze feature ver 1.13

Hi,

I've addressed the comments from Christoph, Steve, Dave, Shaggy and Eric. The points are followings.

- Fixed unlockfs method in ext3/4, xfs, gfs2, jfs and reiserfs so that they always return 0 (success).
Because the caller (thaw_bdev()) should unfreeze a filesystem successfully even in case of unlockfs's failure.

- Fixed xfs's write_super_lockfs so that it returns an error of xfs_trans_reserve() and xfs_trans_commit().

- Fixed gfs2's write_super_lockfs so that it returns -EINVAL in the following case.

Review

Quoted 3 lines
     if (test_bit(SDF_SHUTDOWN, &sdp->sd_flags))
(quoted diff) +1 -1
-        return;
+        return -EINVAL;

- Rename write_super_lockfs/unlockfs of the super block operation freeze_fs/unfreeze_fs to avoid a confusion.

Currently, ext3 in mainline Linux doesn't have the freeze feature which suspends write requests. So, we cannot take a backup which keeps the filesystem's consistency with the storage device's features (snapshot and replication) while it is mounted.
In many case, a commercial filesystem (e.g. VxFS) has
the freeze feature and it would be used to get the consistent backup. If Linux's standard filesystem ext3 has the freeze feature, we can do it without a commercial filesystem.

So I have implemented the ioctls of the freeze feature. I think we can take the consistent backup with the following steps.
1. Freeze the filesystem with the freeze ioctl.
2. Separate the replication volume or create the snapshot with the storage device's feature.
3. Unfreeze the filesystem with the unfreeze ioctl.
4. Take the backup from the separated replication volume or the snapshot.

[PATCH 1/10] VFS: Fix error handling of write_super_lockfs/unlockfs
Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they can return an error.
Rename write_super_lockfs/unlockfs of the super block operation freeze_fs/unfreeze_fs to avoid a confusion.

[PATCH 2/10]-[PATCH 6/10] Fix error handling in write_super_lockfs/unlockfs

                          (ext3, ext4, xfs, gfs2, jfs)

Changed write_super_lockfs so that it returns an error if needed. unlockfs always returns 0.

[PATCH 7/10] reiserfs: Fix error handling in write_super_lockfs/unlockfs
Changed write_super_lockfs/unlockfs so that they always return 0 (success) to keep a current behavior.

[PATCH 8/10] Implement generic freeze feature
The ioctls for the generic freeze feature are below.
o Freeze the filesystem
int ioctl(int fd, int FIFREEZE, arg)
fd: The file descriptor of the mountpoint
FIFREEZE: request code for the freeze
arg: Ignored
Return value: 0 if the operation succeeds. Otherwise, -1

o Unfreeze the filesystem
int ioctl(int fd, int FITHAW, arg)
fd: The file descriptor of the mountpoint
FITHAW: request code for unfreeze
arg: Ignored
Return value: 0 if the operation succeeds. Otherwise, -1

[PATCH 9/10] Remove XFS specific ioctl interfaces for freeze feature
It removes XFS specific ioctl interfaces and request codes for freeze feature.
This patch has been supplied by David Chinner.

[PATCH 10/10] Add timeout feature
The timeout feature is added to "freeze ioctl" to solve a deadlock when the freezer accesses a frozen filesystem. And new ioctl to reset the timeout period is added to extend the timeout period. For example, the freezer resets the timeout period to 10 seconds every 5 seconds. In this approach, even if the freezer causes a deadlock by accessing the frozen filesystem, it will be solved by the timeout in 10 seconds and the freezer will be able to recognize that at the next reset of timeout period.
o Freeze the filesystem
int ioctl(int fd, int FIFREEZE, long *timeout_sec)
fd: The file descriptor of the mountpoint
FIFREEZE: request code for the freeze
timeout_sec: the timeout period in seconds
If it's 0 or 1, the timeout isn't set.
This special case of "1" is implemented to keep the compatibility with XFS applications.
Return value: 0 if the operation succeeds. Otherwise, -1

o Reset the timeout period
This is useful for the application to set the timeout_sec more accurately. For example, the freezer resets the timeout_sec to 10 seconds every 5 seconds. In this approach, even if the freezer causes a deadlock by accessing the frozen filesystem, it will be solved by the timeout in 10 seconds and the freezer can recognize that at the next reset of timeout_sec.
int ioctl(int fd, int FIFREEZE_RESET_TIMEOUT, long *timeout_sec)
fd:file descriptor of mountpoint
FIFREEZE_RESET_TIMEOUT: request code for reset of timeout period
timeout_sec: new timeout period in seconds
Return value: 0 if the operation succeeds. Otherwise, -1 Error number: If the filesystem has already been unfrozen,
errno is set to EINVAL.

Any comments are very welcome.

Cheers, Takashi