Skip to content

Remove SCSI unchecked_isa_dma try 3

Andi Kleen linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21SCSI-ISA-DMA: Add the alloc/get_pages_mask callsinclude/linux/gfp.h+19 -30 replies
2/21SCSI-ISA-DMA: Add blk_q_maskinclude/linux/blkdev.h+5 -00 replies
3/21SCSI-ISA-DMA: Pass gfp to scsi_allocate_commanddrivers/scsi/scsi.c include/scsi/scsi_cmnd.h+32 -180 replies
4/21SCSI-ISA-DMA: Add sense_buffer_isa to host templateDocumentation/scsi/scsi_mid_low_api.txt drivers/scsi/hosts.c drivers/scsi/scsi.c +1 more+16 -40 replies
5/21SCSI-ISA-DMA: Remove unchecked_isa in BusLogicdrivers/scsi/BusLogic.c+59 -180 replies
6/21SCSI-ISA-DMA: Remove unchecked_isa_dma in advansys.cdrivers/scsi/advansys.c+103 -590 replies
7/21SCSI-ISA-DMA: Remove unchecked_isa_dma in gdthdrivers/scsi/gdth.c+62 -190 replies
8/21SCSI-ISA-DMA: Remove unchecked_isa_dma in eata.cdrivers/scsi/eata.c+39 -150 replies
9/21SCSI-ISA-DMA: Remove unchecked_isa_dma in aha1542drivers/scsi/aha1542.c+30 -100 replies
10/21SCSI-ISA-DMA: Remove unchecked_isa_dma in aha152x/wd7000/sym53c416/u14-34f/NCR53c406adrivers/scsi/NCR53c406a.c drivers/scsi/aha152x.c drivers/scsi/sym53c416.c +3 more+124 -370 replies
11/21SCSI-ISA-DMA: Remove GFP_DMA uses in st/osstdrivers/scsi/osst.c drivers/scsi/osst.h drivers/scsi/st.c +1 more+26 -370 replies
12/21SCSI-ISA-DMA: Remove unchecked_isa_dma support for hostdatadrivers/scsi/hosts.c+0 -30 replies
13/21SCSI-ISA-DMA: Use blk_q_mask/get_pages_mask in sg driverdrivers/scsi/sg.c+13 -350 replies
14/21SCSI-ISA-DMA: Rely on block layer bouncing for ISA DMA devices scanningdrivers/scsi/scsi_scan.c+2 -40 replies
15/21SCSI-ISA-DMA: Don't disable direct_io for unchecked_isa_dma in st.cdrivers/scsi/st.c+1 -10 replies
16/21SCSI-ISA-DMA: Remove automatic block layer bouncing for unchecked_isa_dmadrivers/scsi/scsi_lib.c+0 -20 replies
17/21SCSI-ISA-DMA: Remove GFP_DMA use in sr.cdrivers/scsi/sr.c drivers/scsi/sr_ioctl.c drivers/scsi/sr_vendor.c+7 -120 replies
18/21SCSI-ISA-DMA: Remove unchecked_isa_dma from sysfsdrivers/scsi/scsi_sysfs.c+0 -20 replies
19/21SCSI-ISA-DMA: Switch to a single SCSI command pooldrivers/scsi/scsi.c+31 -270 replies
20/21SCSI-ISA-DMA: Finally kill unchecked_isa_dmaDocumentation/scsi/scsi_mid_low_api.txt drivers/scsi/hosts.c include/scsi/scsi_host.h+0 -100 replies
21/21SCSI-ISA-DMA: Convert DMA buffers in ch.c to allocate via the block layerdrivers/scsi/ch.c+10 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH] [0/21] Remove SCSI unchecked_isa_dma try 3

This reposts the patchkit to remove unchecked_isa_dma which was already discussed some time ago. Instead it replaces it with interfaces that declare the mask. Right now those interfaces map back to GFP_DMA eventually, but it is a preparation for using the DMA mask allocator eventually.

The previous time there were some disagreement on where to handle the sense buffer bouncing which was done in low level drivers in Boaz' version of the patchkit. I went back to the original code which keeps sense buffer bouncing in the mid layer, which should be non controversal.

I also removed blk_kmalloc and went back to the blk_q_mask() interfaces.

I believe there were no other controversies, so this should be ready for merging now.

Other main changes was to forward port it to 2.6.27rc8 and doing some retesting.

The changes are also available for pulling from

git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 scsi-dma

Andi Kleen (21):
SCSI-ISA-DMA: Add the alloc/get_pages_mask calls
SCSI-ISA-DMA: Add blk_q_mask
SCSI-ISA-DMA: Pass gfp to scsi_allocate_command
SCSI-ISA-DMA: Add sense_buffer_isa to host template
SCSI-ISA-DMA: Remove unchecked_isa in BusLogic
SCSI-ISA-DMA: Remove unchecked_isa_dma in advansys.c
SCSI-ISA-DMA: Remove unchecked_isa_dma in gdth
SCSI-ISA-DMA: Remove unchecked_isa_dma in eata.c
SCSI-ISA-DMA: Remove unchecked_isa_dma in aha1542
SCSI-ISA-DMA: Remove unchecked_isa_dma in aha152x/wd7000/sym53c416/u14-34f/NCR53c406a
SCSI-ISA-DMA: Remove GFP_DMA uses in st/osst
SCSI-ISA-DMA: Remove unchecked_isa_dma support for hostdata
SCSI-ISA-DMA: Use blk_q_mask/get_pages_mask in sg driver
SCSI-ISA-DMA: Rely on block layer bouncing for ISA DMA devices scanning
SCSI-ISA-DMA: Don't disable direct_io for unchecked_isa_dma in st.c
SCSI-ISA-DMA: Remove automatic block layer bouncing for unchecked_isa_dma
SCSI-ISA-DMA: Remove GFP_DMA use in sr.c
SCSI-ISA-DMA: Remove unchecked_isa_dma from sysfs
SCSI-ISA-DMA: Switch to a single SCSI command pool
SCSI-ISA-DMA: Finally kill unchecked_isa_dma
SCSI-ISA-DMA: Convert DMA buffers in ch.c to allocate via the block layer

 Documentation/scsi/scsi_mid_low_api.txt |    4 +-
 drivers/scsi/BusLogic.c                 |   77 +++++++++++----
 drivers/scsi/NCR53c406a.c               |    8 ++-
 drivers/scsi/advansys.c                 |  162 ++++++++++++++++++++-----------
 drivers/scsi/aha152x.c                  |   29 +++++-
 drivers/scsi/aha1542.c                  |   40 ++++++--
 drivers/scsi/ch.c                       |   16 ++-
 drivers/scsi/eata.c                     |   54 ++++++++---
 drivers/scsi/gdth.c                     |   81 ++++++++++++----
 drivers/scsi/hosts.c                    |    5 +-
 drivers/scsi/osst.c                     |   24 ++---
 drivers/scsi/osst.h                     |    2 -
 drivers/scsi/scsi.c                     |   93 +++++++++++-------
 drivers/scsi/scsi_lib.c                 |    2 -
 drivers/scsi/scsi_scan.c                |    6 +-
 drivers/scsi/scsi_sysfs.c               |    2 -
 drivers/scsi/sg.c                       |   48 +++-------
 drivers/scsi/sr.c                       |    2 +-
 drivers/scsi/sr_ioctl.c                 |   13 +--
 drivers/scsi/sr_vendor.c                |    4 +-
 drivers/scsi/st.c                       |   37 +++----
 drivers/scsi/st.h                       |    2 -
 drivers/scsi/sym53c416.c                |    9 ++-
 drivers/scsi/u14-34f.c                  |   54 ++++++++---
 drivers/scsi/ultrastor.c                |   13 ++-
 drivers/scsi/wd7000.c                   |   48 ++++++---
 include/linux/blkdev.h                  |    5 +
 include/linux/gfp.h                     |   22 ++++-
 include/scsi/scsi_cmnd.h                |    5 +-
 include/scsi/scsi_host.h                |   14 ++-
 30 files changed, 569 insertions(+), 312 deletions(-)