Skip to content

resend of pending TWL patches

David Brownell linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7rtc-twl4030 header cleanupdrivers/rtc/rtc-twl4030.c+1 -90 replies
2/7remove <linux/i2c/twl4030-rtc.h>drivers/rtc/rtc-twl4030.c include/linux/i2c/twl4030-pwrirq.h include/linux/i2c/twl4030-rtc.h+79 -2060 replies
3/7remove <linux/i2c/twl4030-pwrirq.h>drivers/i2c/chips/twl4030-pwrirq.c drivers/mfd/twl4030-core.c drivers/rtc/rtc-twl4030.c +2 more+21 -480 replies
4/7twl4030-core cleanupdrivers/mfd/twl4030-core.c include/linux/i2c/twl4030-madc.h include/linux/i2c/twl4030.h+181 -1412 replies
5/7gpiolib to_irq() featureDocumentation/gpio.txt drivers/gpio/gpiolib.c include/asm-generic/gpio.h+28 -20 replies
6/7OMAP gpios implement new to_irq()arch/arm/plat-omap/gpio.c arch/arm/plat-omap/include/mach/gpio.h+21 -40 replies
7/7twl4030-gpio implements to_irq()drivers/gpio/twl4030-gpio.c+7 -00 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchFelipe Balbi
1/7
2/7A-b
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 2.6.27-rc8-omap 0/7] resend of pending TWL patches

This flushes my queue of TWL (and related) patches that seem ready to merge:

- remove extra headers from RTC driver
- remove RTC header
- remove pwrirq header
- core cleanups
- gpiolib to_irq() feature
- implement to_irq() for OMAP gpios
- ... and for TWL gpios

At that point the twl4030-core code will be ready to enter the MFD queue IMO ... there've not been many review comments other than mine (which were mostly addressed in the "core cleanups" patch above).

The main open issues with respect to the TWL core seem to relate to IRQ handling. I've had a bright idea that I think will solve a bunch of issues at once, but that can/should go separately. And then there will still be the issue of genirq support for threaded IRQs -- which isn't quite available yet.

(One observation is that we should prefer to get drivers in mainline even if they're not yet fully cooked ... and mainline is happy with that model. In this case we'll have cleaned up lots of ragged edges, but not yet many of the IRQ bits.)

- Dave