Skip to content

: Killing qdisc->ops->requeue().

Jarek Poplawski netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 14 patches 15 repliesIn review

Patches in v1 No applies recorded yet

None of the 14 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14]: Killing qdisc->ops->requeue().

The aim of this patch-set is to finish changes proposed by David S. Miller in his patch-set with the same subject from Mon, 18 Aug 2008. The first two patches were applied with some modifications, so, to apply the rest, there were needed some changes.

Original David's patches include additional info, but signed-off-by is removed because of changed context. I expect they will be merged and signed off by David as an author, anyway.

The qdisc->requeue list idea is to limit requeuing to one level only, so a parent can requeue to its child only. This list is then tried first while dequeuing (qdisc_dequeue()), except at the top level, so packets could be requeued only by qdiscs, not by qdisc_restart() after xmit errors.

Thanks,
Jarek P.

 include/net/sch_generic.h |   23 +++++++++------
 net/sched/sch_api.c       |    7 -----
 net/sched/sch_atm.c       |   24 ++--------------
 net/sched/sch_cbq.c       |   37 +------------------------
 net/sched/sch_dsmark.c    |   23 +---------------
 net/sched/sch_fifo.c      |    2 -
 net/sched/sch_generic.c   |   21 +-------------
 net/sched/sch_gred.c      |   21 --------------
 net/sched/sch_hfsc.c      |   30 ++------------------
 net/sched/sch_htb.c       |   46 +------------------------------
 net/sched/sch_multiq.c    |   38 +------------------------
 net/sched/sch_netem.c     |   29 +++-----------------
 net/sched/sch_prio.c      |   31 +--------------------
 net/sched/sch_red.c       |   20 +-------------
 net/sched/sch_sfq.c       |   66 ---------------------------------------------
 net/sched/sch_tbf.c       |   23 +--------------
 net/sched/sch_teql.c      |   11 -------
 17 files changed, 36 insertions(+), 416 deletions(-)