Skip to content

start phasing out legacy GPIO calls

David Brownell linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4remove omap_set_gpio_dataout() and omap_get_gpio_datain()Documentation/arm/OMAP/gpio arch/arm/mach-omap1/board-fsample.c arch/arm/mach-omap1/board-h2.c +37 more+161 -1630 replies
2/4use gpio_direction_input()arch/arm/mach-omap1/board-palmte.c arch/arm/mach-omap1/board-palmz71.c arch/arm/mach-omap1/board-voiceblue.c +19 more+32 -290 replies
3/4remove omap_set_gpio_direction()arch/arm/mach-omap1/board-h2.c arch/arm/mach-omap1/board-palmz71.c arch/arm/mach-omap1/board-sx1.c +21 more+50 -992 replies
4/4use gpio_to_irq()arch/arm/mach-omap1/board-osk.c arch/arm/mach-omap1/board-palmz71.c arch/arm/mach-omap1/board-voiceblue.c +15 more+58 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 2.6.27-omap-git 0/4] start phasing out legacy GPIO calls

Following this are four patches matching $SUBJECT:

- remove omap_set_gpio_dataout() and omap_get_gpio_datain() ... same call syntax, different name, minor code shrink
- use gpio_direction_input()
... minor call syntax change, otherwise not interesting
- use gpio_direction_output(), remove omap_set_gpio_direction() ... different call syntax and initialization model
- use gpio_to_irq()
... at least, outside of static initializers

The third patch might conceivably make trouble; see the patch comments. Ditto the fourth, but IMO that's less likely.

I did test builds for OMAP1, OMAP2420, OMAP2430, and OMAP3430, and tried to make sure all the files affected by this patch got rebuilt. The build breakage was mostly related to McBSP and iomem pointers; nothing affected by these patches.

Two remaining OMAP GPIO calls can be removed a bit later:

	int omap_request_gpio(int gpio);
	void omap_free_gpio(int gpio);

Once that's done, I think it'll be time to move the GPIO code into mach-omap1/mach-omap2 ... the OMAP2/OMAP3 stuff in particular should become a LOT simpler.

- Dave