Implement quotas for OCFS2 (version 2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 patches 0 repliesNew
Patches in v1 No applies recorded yet
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Ocfs2-devel] [PATCH 00/00] Implement quotas for OCFS2 (version 2)
Quoted 37 lines · tristan.ye
Quoted 5 lines · Jan Kara
Hello,
the following patch series implements quotas for OCFS2. The patch series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.gitlinux-nextJan,
Try with linux-next branch on mark's tree this time,still hit a failure at patch 25
[root at ocfs2-test5 linux-next]# patch -p1</kernel/quota-patches/quota-patch25
patching filefs/ocfs2/Makefile
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED -- saving rejects to filefs/ocfs2/Makefile.rejpatching filefs/ocfs2/cluster/masklog.h
patching filefs/ocfs2/dir.c
Hunk #1 FAILED at 82.
1 out of 1 hunk FAILED -- saving rejects to filefs/ocfs2/dir.c.rejpatching filefs/ocfs2/dlmglue.c
Hunk #9 succeeded at 3490 (offset 5 lines).
patching filefs/ocfs2/dlmglue.h
patching filefs/ocfs2/file.c
patching filefs/ocfs2/file.h
patching filefs/ocfs2/inode.h
Hunk #1 succeeded at 144 (offset 2 lines).
patching filefs/ocfs2/ocfs2_fs.h
patching filefs/ocfs2/ocfs2_lockid.h
patching filefs/ocfs2/quota.h
patching filefs/ocfs2/quota_global.c
patching filefs/ocfs2/quota_local.c
patching filefs/ocfs2/super.c
Hunk #3 succeeded at 1077 (offset 1 line).
Hunk #5 succeeded at 1218 (offset 1 line).
Quoted 2 lines
Anyway,i do succeeded to apply these patches with linus's latest mainline 2.6.27 master branch. the tools patch for mkfs also works:),
Hmm, that's a bit strange. I've just rebased my set of patches on top of
linux-next branch in Mark's tree and I got two rejects but in a different patch... Also my latest patch set probably wouldn't work against 2.6.27 because it's already based on xattr and acl changes which aren't in 2.6.27. I'm attaching tarball of the patches just for reference.
Quoted 4 lines
for current testing,seems all POSIX quota
tools(including quotaon,quotaoff and setquota.)failed to be applied on ocfs2-quota? right? the failure may due to the fact that tools can not find 2 hidden quota files?
Yes, tools should print some message that filesystem does not support
quotas or something like that.
Quoted 7 lines
After mkfs with --fs-feature=usrquota,grpquota.... and also mount it with usrquota and grpquota options explicitly specified,seems still failed to enable the quota by quotaon even i did saw these options showed up in
/etc/mtab. the errors was somewhat like i never specified the options when mounting,
[root at ocfs2-test6 quota_examples-0.0.21]# quotaon -vugf /quota/
quotaon: Mountpoint (or device) /quota not found.
Well, the -f option is definitely wrong (that means turn quotas off).
Something like: quotaon -avug
should do the work for you - it will find the filesystem in the /etc/mtab
automatically.
Quoted 5 lines
When i check this quota-supported ocfs2 volume by debufs.ocfs2,do find the 2 quota files under system folder.so,ocfs2 defaultly generate the quota files without a quotacheck like extN did? so how can I refresh/check the files by force?should wait the fsck.ocfs2 to have it come true?
Mkfs creates these two system files (and also node local system files
called aquota0001.user etc). For checking / fixing these files, you have to wait for fsck.ocfs2 support. But I think you can test quite a lot even without it - most of the bugs would not probably result in the corruption of quota file anyway.
Quoted 3 lines
Thus,for current testing, i should expect the quoctl POSXI api to do all things for me? since we can not do any test manually without the help of quota tools. am I understanding the things in a right way?
Yes, quotactl() is the only interface you can use (it is used by quota-tools
as well).
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR