Skip to content

freeze feature ver 1.14

Takashi Sato dm-devel linux-ext4 linux-fsdevel linux-xfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Add error handling of write_super_lockfs/unlockfsDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/buffer.c +9 more+108 -691 reply
1/3Add error handling of write_super_lockfs/unlockfsDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/buffer.c +9 more+108 -690 replies
1/3Add error handling of write_super_lockfs/unlockfsDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/buffer.c +9 more+108 -690 replies
2/3Implement generic freeze featurefs/block_dev.c fs/buffer.c fs/ioctl.c +2 more+121 -102 replies
2/3Implement generic freeze featurefs/block_dev.c fs/buffer.c fs/ioctl.c +2 more+121 -100 replies
2/3Implement generic freeze featurefs/block_dev.c fs/buffer.c fs/ioctl.c +2 more+121 -100 replies
3/3Remove XFS specific ioctl interfaces for freeze featurefs/xfs/linux-2.6/xfs_ioctl.c fs/xfs/linux-2.6/xfs_ioctl32.c fs/xfs/xfs_fs.h+2 -190 replies
3/3Remove XFS specific ioctl interfaces for freeze featurefs/xfs/linux-2.6/xfs_ioctl.c fs/xfs/linux-2.6/xfs_ioctl32.c fs/xfs/xfs_fs.h+2 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] freeze feature ver 1.14

Hi,

We need to discuss about the timeout feature more, so I send patches only of the generic freeze feature.

I've addressed the comment from Shaggy,
combined patches that were divided into each filesystems into one patch because of the avoidance of a bisection.

Currently, ext3 in mainline Linux doesn't have the freeze feature which suspends write requests. So, we cannot take a backup which keeps the filesystem's consistency with the storage device's features (snapshot and replication) while it is mounted.
In many case, a commercial filesystem (e.g. VxFS) has
the freeze feature and it would be used to get the consistent backup. If Linux's standard filesystem ext3 has the freeze feature, we can do it without a commercial filesystem.

So I have implemented the ioctls of the freeze feature. I think we can take the consistent backup with the following steps.
1. Freeze the filesystem with the freeze ioctl.
2. Separate the replication volume or create the snapshot with the storage device's feature.
3. Unfreeze the filesystem with the unfreeze ioctl.
4. Take the backup from the separated replication volume or the snapshot.

[PATCH 1/3] Add error handling of write_super_lockfs and unlockfs
VFS:
Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they can return an error.
Rename write_super_lockfs and unlockfs of the super block operation freeze_fs and unfreeze_fs to avoid a confusion.

ext3, ext4, xfs, gfs2, jfs:
Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that write_super_lockfs returns an error if needed, and unlockfs always returns 0.

reiserfs:
Changed the type of write_super_lockfs and unlockfs from "void" to "int" so that they always return 0 (success) to keep a current behavior.

[PATCH 2/3] Implement generic freeze feature
The ioctls for the generic freeze feature are below.
o Freeze the filesystem
int ioctl(int fd, int FIFREEZE, arg)
fd: The file descriptor of the mountpoint
FIFREEZE: request code for the freeze
arg: Ignored
Return value: 0 if the operation succeeds. Otherwise, -1

o Unfreeze the filesystem
int ioctl(int fd, int FITHAW, arg)
fd: The file descriptor of the mountpoint
FITHAW: request code for unfreeze
arg: Ignored
Return value: 0 if the operation succeeds. Otherwise, -1 Error number: If the filesystem has already been unfrozen,
errno is set to EINVAL.

[PATCH 3/3] Remove XFS specific ioctl interfaces for freeze feature
It removes XFS specific ioctl interfaces and request codes for freeze feature.
This patch has been supplied by David Chinner.

Any comments are very welcome.

Cheers, Takashi