Skip to content

ftrace: code consolidation

Steven Rostedt lkml 1 version Applied

Status from this message: i've applied your 3 patches to tip/tracing/ftrace:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ftrace: ftrace_preempt_disablekernel/trace/trace.h+48 -04 replies
2/3ftrace: insert in the ftrace_preempt_disable functionskernel/trace/ring_buffer.c kernel/trace/trace.c kernel/trace/trace_sched_wakeup.c +1 more+15 -410 replies
3/3ftrace: function tracer with irqs disabledkernel/trace/trace.c kernel/trace/trace.h+40 -15 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] ftrace: code consolidation

[ For 2.6.29 ]

The first two patches makes ftrace function calling and other sensitive tracing use a macro to handle preemption disabling. This removes a lot of duplicate code that works on preventing the scheduler from infinite recursion.

The last patch sets an easy way for the user to either use irq disabling or preemption disabing for the function tracer.

Peter Zijlstra noticed a bit of a trace that was not showing up due to lost traces caused by interrupts when the function tracer was running.

Due to the sensitive nature of the function tracer, it can not allow for recursive tracing, so it needs to disable recursion while it records the trace. But this also means that without disabling interrupts, any interrupt that happens while the trace is happening will be lost from the trace itself.

-- Steve