Skip to content

OMAP3 clock: skip reserved FREQSEL settings

Paul Walmsley linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3OMAP3 clock: remove unnecessary dpll_data dereferencesarch/arm/mach-omap2/clock.c+13 -100 replies
2/3OMAP3 clock: optimize DPLL rate rounding algorithmarch/arm/mach-omap2/clock.c+18 -170 replies
3/3OMAP3 clock: avoid invalid FREQSEL values during DPLL rate roundingarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock24xx.h arch/arm/mach-omap2/clock34xx.h +1 more+71 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] OMAP3 clock: skip reserved FREQSEL settings

Hello,

this series fixes a bug in the OMAP3 DPLL rate rounding code that will attempt to program the DPLL to use an internal clock frequency that does not exist in the FREQSEL table in 34xx TRM 4.7.6.2. This mostly seems to generate warnings, but can potentially hang the system.

As part of this process, improve the DPLL rate rounding algorithm to start from a low divider (N) and count up; this should result in fewer passes through the loop.

Tested on 3430SDP ES2 and a custom ES3 board. Thanks to Peter de Schrijver <[email protected]> for help with these patches.

- Paul

---

text data bss dec hex filename

3574155  189440  108880 3872475  3b16db vmlinux.3430sdp.orig
3574251  189440  108880 3872571  3b173b vmlinux.3430sdp
 arch/arm/mach-omap2/clock.c             |  118 ++++++++++++++++++++++++-------
 arch/arm/mach-omap2/clock24xx.h         |    1 
 arch/arm/mach-omap2/clock34xx.h         |    5 +
 arch/arm/plat-omap/include/mach/clock.h |    1 
 4 files changed, 99 insertions(+), 26 deletions(-)