Skip to content

dmaengine redux

Dan Williams lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 38 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13async_tx, dmaengine: document channel allocation and api reworkDocumentation/crypto/async-tx-api.txt Documentation/dmaengine.txt+68 -680 replies
2/13dmaengine: remove dependency on async_txcrypto/async_tx/async_tx.c drivers/dma/Kconfig drivers/dma/dmaengine.c +4 more+86 -962 replies
3/13dmaengine: up-level reference counting to the module levelcrypto/async_tx/async_tx.c drivers/dma/dmaengine.c drivers/dma/dmatest.c +5 more+118 -1109 replies
4/13dmaengine: centralize channel allocation, introduce dma_find_channelcrypto/async_tx/async_tx.c drivers/dma/dmaengine.c include/linux/dmaengine.h+166 -1422 replies
5/13dmaengine: provide a common 'issue_pending_all' implementationcrypto/async_tx/async_tx.c drivers/dma/dmaengine.c include/linux/async_tx.h +2 more+27 -240 replies
6/13net_dma: convert to dma_find_channelinclude/linux/netdevice.h include/net/netdma.h net/core/dev.c +4 more+5 -590 replies
7/13dmaengine: introduce dma_request_channel and private channelsdrivers/dma/dmaengine.c include/linux/dmaengine.h+159 -1815 replies
8/13dmatest: convert to dma_request_channeldrivers/dma/dmatest.c include/linux/dmaengine.h+44 -714 replies
9/13atmel-mci: convert to dma_request_channel and down-level dma_slavearch/avr32/include/asm/atmel-mci.h arch/avr32/mach-at32ap/at32ap700x.c drivers/dma/dmaengine.c +4 more+62 -1592 replies
10/13dmaengine: replace dma_async_client_register with dmaengine_getcrypto/async_tx/async_tx.c drivers/dma/dmaengine.c include/linux/dmaengine.h +1 more+11 -1340 replies
11/13dmaengine: kill struct dma_client and supporting infrastructuredrivers/dma/dmaengine.c drivers/dma/dw_dmac.c drivers/dma/fsldma.c +6 more+17 -2173 replies
12/13dmaengine: remove 'bigref' infrastructuredrivers/dma/dmaengine.c drivers/dma/iop-adma.c drivers/dma/mv_xor.c +1 more+9 -860 replies
13/13dmaengine: kill enum dma_state_clientdrivers/dma/dmaengine.c drivers/dma/dmatest.c drivers/mmc/host/atmel-mci.c +1 more+14 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] dmaengine redux

The dmaengine subsystem collects and advertises dma channels for two classes of users in the kernel, memory-to-memory offload and traditional device-to-memory DMA. The original design was driven by the memory-to-memory case and is starting to show its limitations now that more device-to-memory DMA users are being planned. The primary difference between the two classes is that memory-to-memory offload is very amenable to channel sharing and is tolerant of dynamic channel changes. Compare this to the device-to-memory case where a channel must be dedicated to a device and may have platform-specific reasons why it cannot talk to a different device.

This rework allows channels to be targeted to a public (mem-to-mem) pool or be reserved for an exclusive private (dev-to-mem) allocation. See [PATCH 1/13] for documentation of the changes. A nice side effect of the rework is:

 24 files changed, 679 insertions(+), 1108 deletions(-)

All review welcomed, especially around the dma_slave changes, or performance impacts of dma_find_channel.

These patches are currently on async_tx.git/upstream, and barring any brown-paper-bag issues will move to linux-next via async_tx.git/next.

git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx.git upstream

---
Dan Williams (13):
dmaengine: kill enum dma_state_client
dmaengine: remove 'bigref' infrastructure
dmaengine: kill struct dma_client and supporting infrastructure
dmaengine: replace dma_async_client_register with dmaengine_get
atmel-mci: convert to dma_request_channel and down-level dma_slave
dmatest: convert to dma_request_channel
dmaengine: introduce dma_request_channel and private channels
net_dma: convert to dma_find_channel
dmaengine: provide a common 'issue_pending_all' implementation
dmaengine: centralize channel allocation, introduce dma_find_channel
dmaengine: up-level reference counting to the module level
dmaengine: remove dependency on async_tx
async_tx, dmaengine: document channel allocation and api rework

 Documentation/crypto/async-tx-api.txt |  135 +++----
 Documentation/dmaengine.txt           |    1 
 arch/avr32/include/asm/atmel-mci.h    |    6 
 arch/avr32/mach-at32ap/at32ap700x.c   |   15 -
 crypto/async_tx/async_tx.c            |  350 ------------------
 drivers/dma/Kconfig                   |    2 
 drivers/dma/dmaengine.c               |  637 +++++++++++++++++++++++----------
 drivers/dma/dmatest.c                 |  111 ++----
 drivers/dma/dw_dmac.c                 |   28 -
 drivers/dma/fsldma.c                  |    3 
 drivers/dma/ioat_dma.c                |    5 
 drivers/dma/iop-adma.c                |   11 -
 drivers/dma/mv_xor.c                  |   11 -
 drivers/mmc/host/atmel-mci.c          |  103 +----
 include/linux/async_tx.h              |   17 -
 include/linux/dmaengine.h             |  148 ++------
 include/linux/dw_dmac.h               |   31 +-
 include/linux/netdevice.h             |    3 
 include/net/netdma.h                  |   11 -
 net/core/dev.c                        |  148 --------
 net/ipv4/tcp.c                        |    5 
 net/ipv4/tcp_input.c                  |    2 
 net/ipv4/tcp_ipv4.c                   |    2 
 net/ipv6/tcp_ipv6.c                   |    2 
 24 files changed, 679 insertions(+), 1108 deletions(-)
 create mode 100644 Documentation/dmaengine.txt
Signature · 2 lines
Regards,
Dan