Fix hibernation regression on Toshiba Portege R500
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 82 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | PCI: Rework default handling of suspend and resumedrivers/ | +59 | 54 replies | |
| 1/3 | PCI: Rework default handling of suspend and resume (rebased)drivers/ | +63 | 0 replies | |
| 1/3 | PCI: Rework default handling of suspend and resume (rebased)drivers/ | +63 | 0 replies | |
| 2/3 | PCI: Suspend and resume PCI Express ports with interrupts disableddrivers/ | +6 | 0 replies | |
| 2/3 | PCI: Suspend and resume PCI Express ports with interrupts disableddrivers/ | +6 | 12 replies | |
| 3/3 | Sound (HDA Intel): Restore PCI configuration space with interrupts offsound/ | +6 | 0 replies | |
| 3/3 | Sound (HDA Intel): Restore PCI configuration space with interrupts offsound/ | +6 | 14 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Fix hibernation regression on Toshiba Portege R500
Hi,
The following three patches address the hibernation/suspend issue described in
http://bugzilla.kernel.org/show_bug.cgi?id=12121 and in the very long thread at
http://lkml.org/lkml/2008/12/1/382.
In short, the problem is that resume (from hibernation and/or suspend-to-RAM) occasionally fails (approximately 20-25% of attempts) in the middle of resuming PCI devices. We were able to find a specific layout of devices within the memory address space in which the failure appeared to be extremely unlikely, but this layout was no really valid for other reasons. We also found out that using the NMI watchdog decreased the probablitily of failure which indicated that the problem could be timing-related.
Next, we started to look at the PCI resume code and we generally agreed that it would be a good idea to restore the standard PCI configuration registers with interrupts disabled. Also, we thought we could move the saving of those registers for some devices into functions executed with interrupts disabled.
I have followed these observations and created the three following patches. With all of these patches applied, I'm not able to reproduce the problem.
Thanks,
Rafael