Skip to content

ocfs2: Add metadata ECC - almost there.

Joel Becker linux-ext4 ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 18 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 18 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/18] ocfs2: Add metadata ECC - almost there.
Quoted 8 lines · Andi Kleen
Quoted 5 lines · Joel Becker

These patches add the metadata ECC code to ocfs2. They have one limitation - they do not ECC directory blocks yet. However, that will only take a simple insertion of the dirblock trailer. With xattr ECC completed, the patches are approaching a final form and are ready for initial review. They are atop my xattr-buckets-2 branch.

Quoted 5 lines

Could you please expand a bit why you chose ECC over more standard CRCs?

My assumption would be normally that if there is disk corruption it won't be single flipped bits, but more large scale corruption. Do you have data/experiences on the contrary?

If you look at our block_check structure, you'll see that it
uses crc32c for the overall block, and then the ECC can attempt to correct a single bit if the crc fails.

Joel

Signature · 9 lines
"If the human brain were so simple we could understand it, we would
 be so simple that we could not."
	- W. A. Clouston

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127