PCI Hotplug: acpiphp wants a 64-bit _SUN
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | PCI Hotplug: acpiphp wants a 64-bit _SUNdrivers/ drivers/ drivers/ | +4 | 5 replies | |
| 2/2 | PCI Hotplug: acpiphp whitespace cleanupdrivers/ drivers/ | +4 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Matthew Wilcox |
|---|---|
| 1/2 | A-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] PCI Hotplug: acpiphp wants a 64-bit _SUN
Hi Jesse,
Here are two patches for acpiphp.
Although Willy's patch 27663c5855b10af9ec67bc7dfba001426ba21222 (ACPI: Change acpi_evaluate_integer to support 64-bit on 32-bit kernels) is now in, the problem we were initially trying to fix before discovering that patch still exists.
The problem is that on certain HP systems, the _SUN method does utilize the full 64 bits. Declaring sun in struct acpiphp_slot as a u32 leads to name collisions on our systems.
The first patch from Justin changes the declaration of sun to unsigned long long. It has been tested and verified that it fixes the name collision issue on our machines.
I also did a build test in a 32-bit x86 environment to make sure we don't get any compiler warnings, and it was clean.
Please consider that patch for 2.6.28. It's late-breaking, but I feel is low-risk.
The second patch is a mere whitespace patch. Since I was in the file anyway, I figured I'd clean it up a bit.
[setting 'let c_space_errors=1' in a .vimrc shows all kinds of wonderful stuff ;) ]
Thanks.
/ac