Skip to content

RFC IrDA 2.6.28 bug fix

Samuel Ortiz netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9irda: Introduce irda_alloc_skbinclude/net/irda/irda.h include/net/irda/irda_device.h net/irda/af_irda.c +12 more+110 -780 replies
2/9irda: stack should call irda_get_skb_cb()include/net/irda/irda_device.h net/irda/ircomm/ircomm_lmp.c net/irda/irlap_frame.c +1 more+12 -80 replies
3/9irda: IrDA drivers should call irda_get_skb_cb()drivers/net/irda/donauboe.c drivers/net/irda/irda-usb.c+15 -130 replies
4/9irda: reserve irda_skb on sock_alloc_send_skb() skbsnet/irda/af_irda.c+11 -60 replies
5/9irda: Introduce irda_dev_alloc_skbinclude/net/irda/irda.h net/irda/irda_device.c+13 -00 replies
6/9irda: Drivers should use irda_dev_alloc_skb() on the RX pathdrivers/net/irda/ali-ircc.c drivers/net/irda/donauboe.c drivers/net/irda/irda-usb.c +11 more+28 -260 replies
7/9irda: Stack RX path callers should use irda_dev_alloc_skbnet/irda/irttp.c net/irda/wrapper.c+3 -20 replies
8/9irda: Add a WARN_ON when our head room is too smallinclude/net/irda/irda_device.h+1 -00 replies
9/9irda: Fix irda_skb_cb sizeinclude/net/irda/irda_device.h+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/9] IrDA 2.6.28 bug fix

Hi Dave,

This is a 9 patches series for IrDA, against your net-2.6 tree. This is an attempt to fix kernel.bugzilla.org bug #11795, where we noticed skb->cb could be altered once submitted to dev_queue_xmit. Since IrDA is using this callback to pass per-skb information, we are now stuffing it in front of skb->data, after allocating the right headroom.

Another solution would be to play with the IrDA physical header and skb_pull our skbs whenever we are physically transmitting the data.

Cheers,
Samuel.