Skip to content

RFC dccp: Working prototype of integrating the modules

Gerrit Renker dccp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dccp: Remove old CCID-module referencesnet/dccp/ccid.c net/dccp/ccid.h net/dccp/ccids/ccid2.c +1 more+0 -160 replies
2/4dccp: Lockless use of CCID blocksnet/dccp/ccid.c net/dccp/ccid.h net/dccp/feat.c+38 -14020 replies
3/4dccp: Add unregister functionnet/dccp/ccid.c net/dccp/ccid.h net/dccp/proto.c+31 -231 reply
4/4dccp: Integrate the TFRC library (dependency)net/dccp/Makefile net/dccp/ccid.c net/dccp/ccid.h +4 more+24 -212 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchArnaldo Carvalho de MeloIan McDonald
1/4
2/4A-b A-b A-b A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC] [Patch 0/4] dccp: Working prototype of integrating the modules

This set addresses the issues in making CCIDs an available part of DCCP.

I am sending this for discussion, it differs in one point from the previous patch - this set does not keep the module loading and locking code.

The rationale for this is that
* at the moment there are only 2 fully standardised CCIDs
* this situation is not likely to change in the foreseeable future (RFC progress is very slow, the update of RFC 3448 for instance took over 1 year and went through 6 revisions)
* so it would only be research prototypes as candidates for the non-builtin case
* and for this I think we are better off temporarily modifying the build process
* this includes CCID-4, since its Internet draft has expired
(http://www.ietf.org/internet-drafts/draft-ietf-dccp-ccid4-03.txt)
* (but for heretics, we still have the "UDP-like" no-op module)

All patches apply on top of Arnaldo's (your) patch to simplify discussion. Awaiting feedback, please do not apply immediately.

Patch #1: Removes CCID module references that were still around. Patch #2: Removes the r/w locks around module loading. Patch #3: Adds a missing ccid_unregister_builtins() function. Patch #4: Integrates the TFRC library (which is a dependency of
CCID-3/4) with DCCP, including necessary initialisation.

I have performed testing with this set yesterday, it worked very well, including module unloading, use of dccp_probe, different links (WiFi/Ethernet/loopback).

The set is also available via the test tree (git/patch/tarball):

	git://eden-feed.erg.abdn.ac.uk/dccp_exp	[subtree `dccp']
	http://  (same host)