Skip to content

vlan, qeth: neigh_setup

[email protected] linux-s390 netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2vlan: add neigh_setupnet/8021q/vlan_dev.c+14 -01 reply
2/2qeth: convert to net_device_opsdrivers/s390/net/qeth_l2_main.c drivers/s390/net/qeth_l3_main.c+34 -461 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/2] vlan, qeth: neigh_setup

Hi Dave,

the qeth_l3 driver uses the neigh_setup function to turn off ARP for IPv4. But since the vlan driver does not support a neigh_setup function I had to add an ugly hack to the qeth_l3_add_vid function (set the neigh_setup function of the vlan device to the function of the real device). With the new net_device_ops this hack will not work any longer so I want to add neigh_setup to the vlan driver.

Following patches add the neigh_setup to vlan and change qeth to use the net_device_ops. Do you see any problems?

Or is there a better way to turn off ARP for IPv4 (we still need neighbour solicitation for IPv6 so IFF_NOARP is no option)?

Thanks,
Frank